gltf-rs / gltf

A crate for loading glTF 2.0
Apache License 2.0
534 stars 124 forks source link

Add more public import facilities #341

Closed digama0 closed 1 year ago

digama0 commented 2 years ago

Fixes #222. New public API:

kvark commented 1 year ago

A bit worrying to see a PR like this, which is well written with a great description, proven to be needed (based on the issue discussion), and has been left without any answer for 9 months.

alteous commented 1 year ago

@kvark, you are right, it is an unreasonable delay and not a good situation for all parties. The delay is due to my own life commitments taking priority than for any other reason. I am working in this space professionally now so you should expect more updates in the near future. @digama0, I apologise for not addressing your PR sooner.

I have been hesitant to extend the import functionality in the past. This is because previous attempts to cater to every possible import scenario (for example, as described in #324) turned out to be overly complicated. Given this is something that is heavily requested, I will reconsider for this use case.

I have some reservations about the proposed API (I would prefer to re-export as suggested) but, given the length of time since the PR was opened, it would only be fair to merge as-is and make cosmetic changes myself.