search

gluc / ahp

Analytical Hierarchy Process (AHP) with R
97 stars 41 forks source link

Suggestion: rename functions like 'Calculate' and 'LoadFile' #1

Closed ghost closed 8 years ago

ghost commented 8 years ago

I can imagine a lot of packages use similar function names; those sound very generic but are there only for a specific package / file format. Maybe 'CalculateAHP', 'LoadFileAHP' would be better? Just an idea.

gluc commented 8 years ago

I absolutely get your point, and I realise I have a very strict view on this. But for me, neither the ubiquitous prefixing (e.g. ahp_calculate) nor your postfix suggestion make sense. In my view, R namespaces already solve this adequately. So you can use simply ahp::Calculate if you fear interference with other packages. Also, e.g. RStudio lists all the ahp functions if you type ahp:: . And explicitly referencing the namespace keeps your code clean and expressive.
What do you think? Or have you encountered situations where writing LoadFileAHP(...) is strictly preferrable to ahp::LoadFile(...)?

ghost commented 8 years ago

Agreed. (The idea just stems from the habit how R coding is done mostly in the wild/in scripts, i.e. calling a function without explicitly stating its package/namespace but doing library() first and then calling the function by its simple name.)