The current implementation of the volume viewer creates all of the meshes for the viewer in one go, computing the FRBs for Data layers first, then going back and computing subset layers based on those, along with excising points in the data layer where a subset is present.
This PR modifies the implementation to compute the meshes for each layer separately. To allow avoiding repeated computation, the method can take in a dictionary of previously computed FRBs so that Data and Subset layers don't compute the same FRB. This means that excising points from the Data layer doesn't happen, but I think that's fine - that's not what's happening in the vispy viewer, so this means that the export will better match the glue view.
Looking ahead, this will allow our setup to better support allowing export for overlaid scatter layers, which is something that the vispy volume viewer supports.
The current implementation of the volume viewer creates all of the meshes for the viewer in one go, computing the FRBs for
Datalayers first, then going back and computing subset layers based on those, along with excising points in the data layer where a subset is present.This PR modifies the implementation to compute the meshes for each layer separately. To allow avoiding repeated computation, the method can take in a dictionary of previously computed FRBs so that
DataandSubsetlayers don't compute the same FRB. This means that excising points from theDatalayer doesn't happen, but I think that's fine - that's not what's happening in the vispy viewer, so this means that the export will better match the glue view.Looking ahead, this will allow our setup to better support allowing export for overlaid scatter layers, which is something that the vispy volume viewer supports.