glue-viz / glue-wwt

WorldWideTelescope viewer in glue
BSD 3-Clause "New" or "Revised" License
2 stars 6 forks source link

Guess lat/lon columns for viewer when appropriate #110

Closed Carifio24 closed 2 months ago

Carifio24 commented 2 months ago

I saw #63 and thought that was an interesting idea, so this PR uses the relevant pywwt to resolve #63 by guessing lat/lon columns when appropriate. To me, "when appropriate" means when adding the first data layer to the viewer - if there was already a layer in the viewer, the choice might clash with what's already selected (whether that's from the automatic selection or what the user has selected), and unexpectedly changing the viewer state from what's already there is obviously not ideal.

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 71.21%. Comparing base (a871957) to head (f6f0135). Report is 8 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #110 +/- ## ========================================== + Coverage 69.19% 71.21% +2.02% ========================================== Files 18 18 Lines 1003 1063 +60 ========================================== + Hits 694 757 +63 + Misses 309 306 -3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Carifio24 commented 2 months ago

Rebased to resolve merge conflicts.

Carifio24 commented 2 months ago

@astrofrog I've added a couple of tests for this behavior