glue-viz / glue-wwt

WorldWideTelescope viewer in glue
BSD 3-Clause "New" or "Revised" License
2 stars 6 forks source link

`runJavaScript()` calls failing on `unexpected keyword argument 'asynchronous'` #85

Open dhomeier opened 2 years ago

dhomeier commented 2 years ago

Describe the bug TestWWTDataViewer.test_save_tour() fails on

>       self.viewer._wwt.widget.page.runJavaScript("tourxml = '';", asynchronous=False)
E       TypeError: runJavaScript() got an unexpected keyword argument 'asynchronous'

on all Python 3.7+ tests although all the Qt* modules seem to be on the same versions as in the 3.6 envs. The docs on https://www.riverbankcomputing.com/static/Docs/PyQt5/api/qtwebenginewidgets/qwebenginepage.html?highlight=runjavascript#methods do not mention any keyword args (or in fact document anything), so no idea for a possible substitute. Just leaving out the kwarg lets the save fail as well (#84).

To Reproduce E.g CI runs on https://dev.azure.com/glue-viz/glue-wwt/_build/results?buildId=2018&view=logs&j=a5e00f2a-e596-5064-edf3-1da4375679ea Details:

================= 14 passed, 1 skipped, 61 warnings in 19.28s =================


but then hang indefinitely on finalising the `Running tox` step.