BaseTestDataViewer has interactive tests causing CI to time out

glue-viz / glue

Linked Data Visualizations Across Multiple Files

http://glueviz.org

Other

736 stars 153 forks source link

BaseTestDataViewer has interactive tests causing CI to time out #2057

Open pllim opened 5 years ago

pllim commented 5 years ago

In testing ejeschke/glue-ginga#30, which has tests inheriting from BaseTestDataViewer, I found that some of the tests generate pop-up window that requires user to click something to close it before the testing can proceed. This causes CI to timeout.

https://github.com/glue-viz/glue/blob/0b4674d6c8d29bc9ab2bdc56f3c99d6fe0ce8438/glue/viewers/common/qt/tests/test_data_viewer.py#L22

dhomeier commented 2 years ago

Just ran into a similar problem in https://github.com/glue-viz/glue/pull/2274#issuecomment-1030987988 when a numpy exception was holding the viewer open. Don't know it this can be fixed within the test or GlueApp, which I think is the function not returning here. The exception handling is probably inherited from QtWidgets.QMainWindow.