glue-viz / glue

Linked Data Visualizations Across Multiple Files
http://glueviz.org
Other
721 stars 152 forks source link

glue 1.19.0 broke jdaviz (cubeviz) #2483

Open pllim opened 2 months ago

pllim commented 2 months ago

Describe the bug

CI failure as reported in:

To Reproduce

Install glue-core 1.19 and jdaviz from main, then run jdaviz test suite.

Expected behavior

Jdaviz CI should not fail.

pllim commented 2 months ago

These PRs were highlights in release notes.

jdaviz does test against dev version of glue stack including glue-core and its devdeps job passed just yesterday (https://github.com/spacetelescope/jdaviz/actions/runs/8690877255/job/23831779573), so whatever that is failing jdaviz must have been merged and released before we had a chance to test against glue-core dev again.

pllim commented 2 months ago

So I think that narrowed it down to either of these (and @rosteen came to the same conclusion as well):

cc @astrofrog

astrofrog commented 2 months ago

I can git bisect it later and see what caused it