search

glushchenko / fsnotes

Notes manager for macOS/iOS
https://fsnot.es
MIT License
6.53k stars 484 forks source link

Opening the Notes List context menu locks up the app #1477

Closed tewe closed 6 months ago

tewe commented 1 year ago

Description

Opening the context menu on a Notes List item reliably beachballs the app, until force quit.

Spin dump

A workaround is using the File menu, which has most of the same items.

To Reproduce

  1. Two-finger tap on any note in the list

Expected behavior

Have the context menu not just open, but also allow a selection from it, without locking up the app.

FSNotes version

6.1.3 (559)

macOS/iOS version

macOS 12.6.2

Additional context

One difference between the File menu and the context menu is that History is a sub-menu. The spin dump shows a lot of Git. The version I first noticed this with included some changes to the Git code. So that's where I'd look.

glushchenko commented 1 year ago

Ho many commits do you have?

tewe commented 1 year ago

git --git-dir=a7cf...git rev-list --count HEAD says 776.

glushchenko commented 1 year ago

It's not much, it's very strange why that is.

tewe commented 1 year ago

time git --git-dir=a7cf...git/ log -- Some.textbundle/text.md takes 1.6 seconds, which seems long but is much much less than what the app needs.

glushchenko commented 1 year ago

I think I reproduced it, looking for a solution

glushchenko commented 1 year ago

Please try this https://github.com/glushchenko/fsnotes/releases/download/6.1.4/FSNotes_6.1.4.zip

tewe commented 1 year ago

Unfortunately that didn't help.

Spin dump

I noticed that some notes take longer than others. This seems more related to how long ago the first revision was than to how many there are.

tewe commented 6 months ago

I can no longer reproduce this in FSNotes 6.8.0 for macOS. Thanks!