search

gma / tconsole

Testing console for Rails. Helps out with test performance and also makes it easier to run specific tests
177 stars 18 forks source link

Only patch MiniTest once #76

Closed jdrnetworking closed 10 years ago

jdrnetworking commented 10 years ago

patch_minitest is called twice in TConsole::MiniTestHandler.preload_elements. Removing the second call has the side effect of resolving gma/tconsole#75

gma commented 10 years ago

Thanks again for doing this. I've just spent a while trying to test it, but there seem to be other problems with Rails 4, Ruby 2.1.1 and the version of MiniTest that ships with Ruby (4.7.5) that prevents Tconsole from launching the test suite in a dummy Rails app anyway, so I'm just going to run with this.

I want to get Tconsole thoroughly tested so we can start fixing stuff like this a little more confidence that we're not breaking stuff.

jdrnetworking commented 10 years ago

No problem. !timings is something that has never worked for me, either. Maybe I'll tackle that next.

gma commented 10 years ago

Oh dear – I've never had a problem with !timings (though I am still runing 1.2.4 with Rails 3.2 – I'm expecting most of my time spent upgrading to Rails 2.4 and Ruby 2.1.x to actually be spent updating Tconsole!).