It would make sense both to refactor the code and to give it a bette name than just adding a prime.
The two first arguments are typ and func, the last is the list of reification rules that are to be wrapped in the CFix. The two implicit arguments are the Reify type class for typ and the partial view to the lookup table (which the primed version lacks).
Would it make sense to factor out the common code here? Maybe make something that takes both before and after commands and then instantiate it appropriately for both reify_func and reify_func'?
It would make sense both to refactor the code and to give it a bette name than just adding a prime.
The two first arguments are typ and func, the last is the list of reification rules that are to be wrapped in the CFix. The two implicit arguments are the Reify type class for typ and the partial view to the lookup table (which the primed version lacks).
On 11 Dec 2016, at 03:26, Gregory Malecha notifications@github.com<mailto:notifications@github.com> wrote:
@gmalecha requested changes on this pull request.
Tiny bit of cleanup.
In theories/Reify/ReifyView.vhttps://github.com/gmalecha/mirror-core/pull/102#pullrequestreview-12358406:
Would it make sense to factor out the common code here? Maybe make something that takes both before and after commands and then instantiate it appropriately for both reify_func and reify_func'?
In theories/Reify/ReifyView.vhttps://github.com/gmalecha/mirror-core/pull/102#pullrequestreview-12358406:
Arguments reifyfunc { } . Arguments Reifyfunc { } . + +Arguments reifyfunc' {} _. +Arguments Reifyfunc' {} _.
What are the first two arguments to this function?
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/gmalecha/mirror-core/pull/102#pullrequestreview-12358406, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AE_rNaVgAbpX2eVPP9YQcA3paSMYo-Fiks5rG187gaJpZM4LJ0RJ.