Add cultivar tests with quotes and apostrophes

gnames / gnparser

GNparser normalises scientific names and extracts their semantic elements.

MIT License

38 stars 4 forks source link

Add cultivar tests with quotes and apostrophes #171

Closed tobymarsden closed 3 years ago

tobymarsden commented 3 years ago

Just a few additional tests covering the existing gnparser behavior around cultivar names:

Straight single quotes / apostrophes, e.g. Sarracenia flava 'Maxima'
Straight double quotes, e.g. Amorphophallus konjac "Nightstick"
Typographic/curly single quotes, e.g. Colocasia esculenta ‘Black Magic’
Typographic/curly double quotes, e.g. Spathiphyllum “Mauna Loa”

dimus commented 3 years ago

These tests do not change the behavior of the parser, do you want them just to give a clear illustration of how these cultivars are parsed?

tobymarsden commented 3 years ago

@dimus Right! I'd like to see the response to the kind of data I'm feeding gnparser explicitly documented, even if it's not all being parsed yet.

Would you also consider a PR to implement cultivar epithet parsing? Or would you require full ICNCP support, e.g. cultivar groups?

dimus commented 3 years ago

@tobymarsden if you feel adventurous enough and want to play with https://github.com/gnames/gnparser/blob/master/ent/parser/grammar.peg, such PR would be very nice to have, or you can propose input/output format for such names and we will figure out how to deal with them.

dimus commented 3 years ago

I do not see problems in adding cultivar support incrementally.

tobymarsden commented 3 years ago

@dimus Thanks very much! I've barely touched golang and it's been a few years since I used PEG so you may have... thoughts... when you get the PR, but I'll give it a shot. Appreciate all your work here -- gnparser has been very nice to use.

tobymarsden commented 3 years ago

@dimus I've given this a shot here, for whatever it's worth! #173