panic runtime error with names containing ":" two or more times

abubelinha commented 3 years ago

Hello again. I am testing gnparser with some difficult names, and I found different behaviour depending on the input way (Windows 7):

When parsing a file text with those names, it goes perfectly (of course not all names are completely parsed, but gnparser is able to finish correctly).
But when I input the same files one by one, sometimes raises an error panic: runtime error: invalid memory address or nil pointer dereference

c:\>C:\gnparser-v1.3.3-win-64\gnparser -f pretty "Plantago paludosa FIORI, A. - Nuova flora analitica d'ltalia (ed. 2). S.n., Firenze, 1923-1929. 1/1: [1]-160. 1923 (mars); 1/2: 161-320. 1923 (juil.); 1/3: 321-480. 1923 (déc.);"

panic: runtime error: invalid memory address or nil pointer dereference
[signal 0xc0000005 code=0x0 addr=0x28 pc=0x9332b9]

goroutine 1 [running]:
github.com/gnames/gnsys.FileExists(0xc000118000, 0xb2, 0xc350, 0x0, 0x1f90)
        /home/dimus/go/pkg/mod/github.com/gnames/gnsys@v0.1.1/gnsys.go:33 +0x99
github.com/gnames/gnparser/gnparser/cmd.parse(0xc000118000, 0xb2, 0x2, 0x4, 0xc350, 0x0, 0x1f90, 0x0, 0x0)
        /home/dimus/code/golang/gnparser/gnparser/cmd/root.go:206 +0x85
github.com/gnames/gnparser/gnparser/cmd.glob..func1(0xe3ba00, 0xc0000aa000, 0x1, 0x3)
        /home/dimus/code/golang/gnparser/gnparser/cmd/root.go:102 +0x245
github.com/spf13/cobra.(*Command).execute(0xe3ba00, 0xc00004a050, 0x3, 0x3, 0xe3ba00, 0xc00004a050)
        /home/dimus/go/pkg/mod/github.com/spf13/cobra@v1.1.1/command.go:854 +0x2c2
github.com/spf13/cobra.(*Command).ExecuteC(0xe3ba00, 0xe46be0, 0x0, 0xc000039f78)
        /home/dimus/go/pkg/mod/github.com/spf13/cobra@v1.1.1/command.go:958 +0x375
github.com/spf13/cobra.(*Command).Execute(...)
        /home/dimus/go/pkg/mod/github.com/spf13/cobra@v1.1.1/command.go:895
github.com/gnames/gnparser/gnparser/cmd.Execute()
        /home/dimus/code/golang/gnparser/gnparser/cmd/root.go:110 +0x38
main.main()
        /home/dimus/code/golang/gnparser/gnparser/main.go:26 +0x27

At a first glance, I thought there could be a limit in the length of the names which I can parse this way. But oddly, when I added some random words at the end of the name to make it longer, it was correctly parsed by gnparser (of course, warning about the long tail ... but without raising any errors).

Please compare (same name, but with a long right-added random string):

c:\>C:\gnparser-v1.3.3-win-64\gnparser -f pretty  "Plantago paludosa FIORI, A. - Nuova flora analitica d'ltalia (ed. 2). S.n., Firenze, 1923-1929. 1/1: [1]-160. 1923 (mars); 1/2: 161-320. 1923 (juil.); 1/3: 321-480. 1923 (déc.); bombom chekevara bebechura conga bombom chekevara bebechura conga bombom chekevara bebechura conga"
{
  "parsed": true,
  "quality": 4,
  "qualityWarnings": [
    {
      "quality": 4,
      "warning": "Unparsed tail"
    },
    {
      "quality": 2,
      "warning": "Author in upper case"
    }
  ],
  "verbatim": "Plantago paludosa FIORI, A. - Nuova flora analitica d'ltalia (ed. 2). S.n., Firenze, 1923-1929. 1/1: [1]-160. 1923 (mars); 1/2: 161-320. 1923 (ju
il.); 1/3: 321-480. 1923 (déc.); bombom chekevara bebechura conga bombom chekevara bebechura conga bombom chekevara bebechura conga",
  "normalized": "Plantago paludosa Fiori \u0026 A.",
  "canonical": {
    "stemmed": "Plantago paludos",
    "simple": "Plantago paludosa",
    "full": "Plantago paludosa"
  },
  "cardinality": 2,
  "authorship": {
    "verbatim": "FIORI, A.",
    "normalized": "Fiori \u0026 A.",
    "authors": [
      "Fiori",
      "A."
    ]
  },
  "tail": " - Nuova flora analitica d'ltalia (ed. 2). S.n., Firenze, 1923-1929. 1/1: [1]-160. 1923 (mars); 1/2: 161-320. 1923 (juil.); 1/3: 321-480. 1923 (déc.)
; bombom chekevara bebechura conga bombom chekevara bebechura conga bombom chekevara bebechura conga",
  "id": "e0c79987-32e7-5c43-9f07-1aee82442af6",
  "parserVersion": "v1.3.3"
}

I found the same problem in several names (source):

Androsace imbricata CADEVALL I DIARS, J. & P. FONT I QUER - 9. - Flora de Catalunya. Institut d'Estudis Catalans, Barcelona, 1934-1937. 4: [viii], [1]-481. "1932" [1934]; 5: [1]-45 Plantago altissima JAHANDIEZ, E. & R. MAIRE - Catalogue des plantes du Maroc. Minerva, Lechevalier, Alger, 1931-1934. 1: [I]-XL, [1]-[160]. 1931; 2: [vi], [161]-[558]. 1932; 3: [L Plantago paludosa FIORI, A. - Nuova flora analitica d'ltalia (ed. 2). S.n., Firenze, 1923-1929. 1/1: [1]-160. 1923 (mars); 1/2: 161-320. 1923 (juil.); 1/3: 321-480.1923 (déc.);

I guess it has something to do with names containing at least 2 repetitions of the ":" character, AND less than 230 characters. (the problem does not happen if the name length goes beyond 230 characters).