Open ysc3839 opened 2 years ago
The app works great, tested it on 1.17.1. I would still like to provide suggestions for some enhancements,
Bottom
will still retain its use case, but when a player wants something quick, BBOR style of rendering might be easier.Everything following this are minor nitpicks,
'_tick'
runs even if the player is not moving 'on_move'
event might come in handy here.Enabled
and Disabled
depends on gamerule sendCommandFeedback
. Traditional print might be better for servers that have it disabled.draw_radius
is increased and someone goes near a mob farm with roof broken in a massive area. I think the large amount of boxes can cause some performance issues.task()
but I think it would help a lot, if someone increases the draw radius to a big number.strict
does not really serve any purpose here.chunk_size
& block_name
specifically.Regardless of these nitpicks, the app works great with my limited testing.
@SurfingDude-1182 Thank you for your suggestions!
on_move
would trigger more frequent. It's a good idea to check player's chunk before calculating.task()
would not increasing MSPT, because Scheduled functions run at the end of the tick
(link). I will try using task()
to see if it's better.It's very slow when using task()
. I set DRAW_RADIUS
to 4, with task it takes 2138ms, without task only 73ms.
Updated. Add shapes cache. It will only calculate when the player move to another chunk.
Updated. Add shapes cache. It will only calculate when the player move to another chunk.
Yep, this is exactly what I had in mind.
Find single bedrock on top of the nether. Just like the "Bedrock Ceiling" feature of BoundingBoxOutlineReloaded. Type
/single_bedrock
to turn on rendering, and type again to turn off. It checks 9x9 chunks around the player on every 20gt. It seems that carpet shapes can be occluded by blocks. (Is there an option to make shapes always visible behind blocks?) So if the boxes are occluded, type/single_bedrock bottom
to make it from y=0 to y=127, type again to turn off.Tested on 1.18.2.
Screenshots: