search

gnif / LookingGlass

An extremely low latency KVMFR (KVM FrameRelay) implementation for guests with VGA PCI Passthrough.
GNU General Public License v2.0
4.64k stars 257 forks source link

Libvirt docs touchup #1127

Closed majcosta closed 3 months ago

majcosta commented 3 months ago

if accepted, please squash

majcosta commented 3 months ago

Rationale: image

gnif commented 3 months ago

Looks good but please squash these two commits into one and use the naming convention for commits on this project, ie:

[doc] kvmfr/libvirt: change double quotes to single quotes

Also be sure to add yourself to the AUTHORS file

gnif commented 3 months ago

@JJRcop until the issues I raised are addressed this still needs work.

JJRcop commented 3 months ago

@majcosta Because you're using the GitHub website to make these changes, unless you download Git onto your computer (or a GUI client), you cannot complete the changes requested and will have to start over with a new Pull Request, keeping in mind to name your commit following our naming convention as noted.

You may want to use github.dev to start over. It's an online VS code editor made by GitHub that lets you easily edit 2 or more files in the same commit.

Otherwise, we won't make these changes for you. We recommend downloading a git client for best results especially if you plan to continue contributing to open source projects like Looking Glass in the future.

majcosta commented 3 months ago

ok, done