Default icons to be replaced with symbolic ones

[0rAX0]

Icons that need fixing:

• chrome://global/skin/icons/find.png
• webapps-notification (chrome://browser/skin/webapps-16.png)

[seleznev]

Update:

• New window
• Subscribe
• Cut
• Copy
• Paste
• Sync
• Tab Groups
• Forward/Backward in small sizes

Also I added animation for the sync button. Please test it.

[0rAX0]

Thanks. I can't test the 'Sync' but I'll assume it's working.

[0rAX0]

@seleznev The sync animation a little too slow. :/

[seleznev]

0rAX0, maybe... I don't know. =( You can fix time in "/ Sync button (active) /" block of browser.css.

[0rAX0]

Updated bug report.

[seleznev]

@0rAX0, you can create icons for all state of the Tab Groups button? :)

https://github.com/adwaita-firefox-team/adwaita-firefox/blob/master/theme/chrome/browser/tabview/tabview.png

I added icon for the New window button. It is not good, but I don't know how create a better icon.

[0rAX0]

Whoa! I'll try adding these in the next commit. :)

[seleznev]

@0rAX0, please look it and fix if needed:

• New window
• Tab Groups

=)

[0rAX0]

Thanks! Updated report.

[seleznev]

Please add to list this icons:

• default-notification (chrome://global/skin/icons/information-16.png)
• geo-notification (chrome://browser/skin/Geolocation-16.png)
• addons-notification (chrome://mozapps/skin/extensions/extensionGeneric-16.png)
• indexedDB-notification (chrome://global/skin/icons/question-16.png)
• password-notification (chrome://mozapps/skin/passwordmgr/key-16.png)
• webapps-notification (chrome://browser/skin/webapps-16.png)
• plugins-notification (chrome://mozapps/skin/plugins/pluginGeneric-16.png)

=)

[0rAX0]

Done. :)

[0rAX0]

Done:

• default-notification (chrome://global/skin/icons/information-16.png)
• geo-notification (chrome://browser/skin/Geolocation-16.png)
• indexedDB-notification (chrome://global/skin/icons/question-16.png)
• password-notification (chrome://mozapps/skin/passwordmgr/key-16.png)

Updated report.

[0rAX0]

Done:

• addons-notification (chrome://mozapps/skin/extensions/extensionGeneric-16.png)
• plugins-notification (chrome://mozapps/skin/plugins/pluginGeneric-16.png)

Updated report.

[seleznev]

@0rAX0, please move theme/chrome/browser/symbolic/extensions.svg to images/extensions.svg. This file is unneeded in XPI. =)

And I have two questions.

1. What extension have a lamp icon? I cannot find it. =(
2. What state for colored icons?

And last, your icons the best! Thank you! =)))

[0rAX0]

Oops! Done. :P

1. Clearly > http://evernote.com/clearly
2. Discussed briefly in

Thank you. :)

[0rAX0]

BTW, Clearly already has a nice icon, you don't need to waste time on it. I made it just in case(and for fun). :)

[seleznev]

@0rAX0, I changed icon of Ghostery. I used colored icon for default and #4d4d4d + opacity for disabled state. It it fine or not? %)

[0rAX0]

Thanks! I'll add a colored 'hover' state for Feedly and we'll see with the team what's the best behavior we should keep:

• Colored for active.
• Colored for needs-attention.
• Colored for hover.
• Always grey.
• Always colored.

. Otherwise, we'll revert back to the dark grey for everything. :)

[0rAX0]

Please test. (the hover is a little too bright in 'master' though. :/)

[seleznev]

@0rAX0, You don't add feedly-grayscale.svg in repo. =)))

[0rAX0]

I'm out of coffee. :)

[seleznev]

So, I think using colored icons for hover/active state is looked not good. =\

[garrett]

Oh, I totally overlooked these icons:

• Scriptish
• Stylish
• Translate
• Firebug

The reason? The icons are so bad that I don't include them in my toolbar. But some of these could be useful to have.

Update: Oh, you got Stylish already! Awesome!

Update 2: I'll get the ones on this list.

[seleznev]

Stylish

??? I think, it is good now. =(

[garrett]

Also, we should have a Pinboard icon too. I can also draw this.

Update: Actually, Pinboard's not that bad as-is… it's just a little darker. Still…

[seleznev]

@garrett, and all of this for 15.1?

[garrett]

Well, sure, if we can get it in. (:

[0rAX0]

@garrett This thread is for default icons. There is #69 for extensions. :D

If it's possible, you can add any icon you make to /images/extensions.svg file.

Also, we need your opinion about the colored hover effect(and all the listed possibilities above), please pull the latest changes and test the Feedly icon and tell us what you think.

We also need @pulb and @marb for this. :)

@seleznev Is there a fixable problem or you just don't like it period? :)

[garrett]

Oops. Sorry. I got the threads confused. I think I had both opened in tabs, and selected the wrong tab. ):

[garrett]

Yeah, let's not used colors for hover or active. Color should only be used for notification, if anything.

[seleznev]

@0rAX0, hmmm...

I think colored icons is great for processing buttons (syncing, etc) or notices buttons (Ghostery for ex.). If we used it and in hover, state of buttons will not obvious for users.

[0rAX0]

No worries.

OK you win, let's not use the hover thing. We'll keep it for sync... though. :)

[seleznev]

Please add in list:

• Tag's icon
• Action icon tab (chrome://browser/skin/actionicon-tab.png)

[0rAX0]

• Tag's icon
• Action icon tab (chrome://browser/skin/actionicon-tab.png)

[seleznev]

@0rAX0, thank you! =))

[seleznev]

Icons in search bar(ctrl+f).

For it need 2 symbolic icons:

1. chrome://global/skin/icons/wrap.png
2. chrome://global/skin/icons/find.png

"No-symbolic" checkbox - it's good? %) And input with red background and blue border (if phrase not found)?

[0rAX0]

I'll try to fix the 'find' toolbar this evening. :)

[0rAX0]

Sorry for taking so long. The 'find' toolbar is almost done, I just need to decide on a 'highlight' icon and tweak things:

[seleznev]

@0rAX0, very nice!) But may me right/left arrow need change to down/up? What you think about it? =)

[0rAX0]

Yes, I agree. :)

[garrett]

Wow! that's looking great.

I also agree about up/down. The text is almost always higher or lower on the page (and not on the same line), so that makes perfect sense.

[seleznev]

@0rAX0, @garrett, @gnome-integration-team: What of icon's style (tango or symbolic) we should use in menu?

// I don't like as it look now. :-1:

[garrett]

@seleznev: Simple: no icons in menus.

[seleznev]

@garrett, I can't agree with it. I think we need support different users settings.

[0rAX0]

@seleznev Do you use icons in the menu?

[garrett]

The standard for GNOME and GTK+ apps is to not have icons in the menus. If you want to add icons in the menus, then it should be an optional tweak, and not on by default.

[seleznev]

@garrett, problem in different style of some icons (most in tango, but some in symbolic). No in show/hide icons. Show/hide is configured in GNOME Tweak Tool.

@0rAX0, last 2 hour ;)

[seleznev]

I just want see icons in one style. =)

[garrett]

Oh? Does the setting in GNOME Tweak Tool also apply to Firefox? (Interesting...)

[seleznev]

Why not? GNOME Tweak Tool just change settings in dconf. And Firefox use GTK2. =)