Check test setup work on `node js` v10 and v12

gnosischain / posdao-test-setup

Integration tests setup for POSDAO, a Proof of Stake Decentralized Autonomous Organization consensus

https://forum.poa.network/c/posdao

14 stars 17 forks source link

Closed varasev closed 5 years ago

varasev commented 5 years ago

posdao-test-setup probably doesn't work with node js v12 because the web3 < v1.2.0 uses deprecated scrypt package. This should be fixed in web3 1.2.0: https://github.com/ethereum/web3.js/issues/2913#issuecomment-521039254

phahulin commented 5 years ago

The problem with node 12 still remains in keythereum lib which uses scrypt. Opened an issue: https://github.com/ethereumjs/keythereum/issues/79

varasev commented 5 years ago

The problem with node 12 still remains in keythereum lib which uses scrypt

I think we could get rid of the keythereum and use web3.eth.accounts features - seems it allows doing the same things keythereum allows

varasev commented 5 years ago