gnuradio / pmt

pmt
GNU Lesser General Public License v3.0
11 stars 11 forks source link

Remove get_ functions #40

Closed jsallay closed 2 years ago

jsallay commented 2 years ago

We define several functions such as get_scalar, get_vector, etc. All of the classes already have a constructor that takes in a pmt that should be the same thing, with the same error checking. I don't think there is value is having: auto x = get_scalar<float>(p) vs auto x = scalar<float>(p). The second case requires less typing and is a little cleaner.

jsallay commented 2 years ago

@mormj Would this cause you any heartburn?

mormj commented 2 years ago

Not at all. Just a global search and replace from my perspective. Having less redundancy in the code is better!

jsallay commented 2 years ago

Removed some time ago.