search

gnustep / libs-gui

The GNUstep gui library is a library of graphical user interface classes written completely in the Objective-C language; the classes are based upon Apple's Cocoa framework (which came from the OpenStep specification). *** Larger patches require copyright assignment to FSF. please file bugs here. ***
http://www.gnustep.org
GNU General Public License v3.0
278 stars 102 forks source link

Reduce code duplication in GSThemeDrawing table/outline view drawing methods #262

Closed gcasa closed 6 months ago

gcasa commented 6 months ago

Per discussions with @fredkiefer I am working through the code here to clean up and reduce duplication.

gcasa commented 6 months ago

As it turns out, the xib is NOT split into separate nibs as I had originally thought. It is possible to register nibs for a given identifier, but the build process does not split the xib out. I was confused by an example I encountered in my research.

fredkiefer commented 6 months ago

If I remember correctly there is also quite some duplication in drawing the special NSOutlienView column. Could you please extract that as well?

gcasa commented 6 months ago

Yep. Will do.

gcasa commented 6 months ago

If I remember correctly there is also quite some duplication in drawing the special NSOutlienView column. Could you please extract that as well?

Done. I am working right now on making sure the icon for expansion and the area that the mouse is supposed to click on line up better and that the image is displayed in a more centered way.

gcasa commented 6 months ago

Made some adjustments to the mouse interaction. Please take a look and see if you approve of all of the changes. Thanks @fredkiefer I hope you feel better soon.

gcasa commented 6 months ago

Looks good to me

Thanks @fredkiefer 🙏