gnuton / asuswrt-merlin.ng

Extends the support of Merlin firmware to more ASUS routers
Other
1.42k stars 82 forks source link

LED Control Scripts - WiFi LEDS Not Turning back on TUF AX5400/DSL-AX82U #172

Open shauno100 opened 2 years ago

shauno100 commented 2 years ago

Router Model Affected TUF AX-5400

Firmware Version Affected 386.5_2-gnuton0

Is this bug present in upstream Merlin releases too? Can't confirm as this router is not officially supported by Merlin

Describe the bug I have enabled scheduled LED control as per https://github.com/RMerl/asuswrt-merlin.ng/wiki/Scheduled-LED-control and when the "/jffs/scripts/ledson.sh" command is run after the LEDs are turned off with the equivalent ledsoff.sh script, all the correct LEDs turn back on except the WiFi 2.4Ghz and 5Ghz LEDs. When i reboot the router all the LEDs turn back on (including 5Ghz WiFi LED). Seems to be a compatibility bug with the LED control system on this particular model and Merlin's "service restart_leds" service maybe?

NOTE: I only use 5Ghz WiFi on my TUF AX5400 so assuming same issue with 2.4Ghz LED but can't be certain as i haven't tested. Definately an issue with 5Ghz LED though.

To Reproduce Steps to reproduce the behavior:

  1. Go to https://github.com/RMerl/asuswrt-merlin.ng/wiki/Scheduled-LED-control and create services-start, ledsoff.sh and ledson.sh scripts as per the instructions.
  2. Reboot router
  3. SSH into router and run the command without quotes "/jffs/scripts/ledsoff.sh" you will be presented with "Done" message - LEDs are now turned off correctly on router.
  4. Now run without quotes "/jffs/scripts/ledson.sh" and notice the WAN, LAN and Power LEDs turn back on successfully but the WiFi 5Ghz and 2.4Ghz LEDs remain off. Only a reboot of router will turn the WiFi LEDs back on.

Expected behavior WiFi 2.4Ghz/5Ghz LEDs to turn back on as intended when "ledson.sh" script is run either manually or via the scheduled crontab job.

trebleta commented 2 years ago

I get something like this on the DSL AX82U. If i disable the leds via the web UI then try to enable nothing comes back on. Same in lastest beta 2 firmware.

shauno100 commented 2 years ago

I doubt anything can be done about this considering i opened this ticket 3 months ago with no response at all from the developer. If this is the case then the ticket can be closed.

trebleta commented 2 years ago

No he has said it's a problem his trying to fix, on snbforum

trebleta commented 2 years ago

Quick question if you use the asus mobile app can you turn on off etc, for me on my dsl ax82u that works. Yet via any other way they will not come on including trying to turn back on via the app if the app did not turn it off in the first place. Rebooting fixs

gnuton commented 2 years ago

@shauno100 this should have been fixed. if you have time please check the latest beta.

gnuton commented 2 years ago

checked the issue is still there.

trebleta commented 2 years ago

Maybe try to use the same way the mobile app controls the leds

gnuton commented 2 years ago

@trebleta I have investigated the issue and I am working on a fix.

shauno100 commented 2 years ago

@gnuton thanks for looking into the issue, unfortunately I am no longer using the TUF AX5400 router so cannot test. Hopefully you're able to get the LED issue fixed though 🙂

gnuton commented 2 years ago

Sure no problem at all. Thanks for reporting it

On Mon, Jul 11, 2022, 13:36 shauno100 @.***> wrote:

@gnuton https://github.com/gnuton thanks for looking into the issue, unfortunately I am no longer using the TUF AX5400 router so cannot test. Hopefully you're able to get the LED issue fixed though 🙂

— Reply to this email directly, view it on GitHub https://github.com/gnuton/asuswrt-merlin.ng/issues/172#issuecomment-1180301702, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEMYRBZK3DLKTKJVGC3CKLVTQBNNANCNFSM5SKWUZPA . You are receiving this because you were mentioned.Message ID: @.***>

trebleta commented 2 years ago

Just wanted to say when I was saying leds I did mean the RGB

gnuton commented 2 years ago

TUF-AX5400 should be fixed in the last beta4, but DSL-AX82U had not been fixed yet.

trebleta commented 2 years ago

Any update on this?

gnuton commented 2 years ago

Nn updates about the dsl-ac82u. I tried to fix it didn't work the code is much compels there and i may have missed something.

trebleta commented 2 years ago

Well on the offical you can completely control the RGB on the main web ui page, maybe just copy and add that part to your merlin. Screenshot_20220903-161729_Chrome

trebleta commented 2 years ago

And look how the offical turns it off and on and add to the led/ rgb control script

trebleta commented 2 years ago

I am a coder, just old skool basic, c++ pascal

gnuton commented 2 years ago

That part works. You can switch on and off aura. The part which does not work is switching on again the 4 LEDs on the left side. The code which handles the gpios for the LEDs is C so you should familiar with the code. :)

On Sat, Sep 3, 2022, 17:21 trebleta @.***> wrote:

I am a coder, just old skool basic, c++ pascal

— Reply to this email directly, view it on GitHub https://github.com/gnuton/asuswrt-merlin.ng/issues/172#issuecomment-1236142147, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEMYRCC7KL6B5KMZFICURTV4NUHHANCNFSM5SKWUZPA . You are receiving this because you were mentioned.Message ID: @.***>

trebleta commented 2 years ago

If you send me that bit of code, I should be able to yes, before it was turning the RGB off and not back on so that side is now fixed?

trebleta commented 2 years ago

Am sorry I have not tried you firmware since I had dsl problems. I'm still having 1-2 problems, also 1-2 issues I'm reporting to asus at mo. 1 to do with wifi, other DDNS.

gnuton commented 2 years ago

No worries. Using stock firmware is not a crime ;) i will update this when this is issue gets fixed. Have a nice weekend