gnuton / asuswrt-merlin.ng

Extends the support of Merlin firmware to more ASUS routers
Other
1.42k stars 82 forks source link

Why do problems solved in Merlin appear again ? #622

Closed ajay-gh closed 2 months ago

ajay-gh commented 2 months ago

This is not really a specific, new bug (report), rather a question concerning "issues" already reported.

I understood that the purpose of this projects is to add more Asus routers to the list of supported routers (example the RT-AX58U v2) - without interfering with the functionality and integrity of Merlin releases. I assumed that you took the original Merlin firmware code (e.g. 3004_388.7_0) and made minor changes in a limited number of places in order to achieve this goal. In other words, I assumed that the bulk of the code remains working and stable. No need to continuously perform additional testing (not the dev, not the user) for each release or update. If that assumption was correct, how come a feature like the VPN client's kill switch (issue 595) - which works fine in the Merlin firmware for a long time - does no longer work and needs to be reported and eventually fixed ?

Hope you don't mind explaining. Such an explanation helps building trust when using a "custom version" (more or less unknown) of a "brand name" like Merlin. Please do not misunderstand, this is not a complaint. Your work is valuable and appreciated, but in some cases trust is vital and all a user can have.

Nullvoid3771 commented 2 months ago

“ I cannot support every single model on my own. Gnuton has been supporting multiple models for many years by now. If you don't like that, then sorry - that's just the way it is. I have a finite amount of time I can devote to this project. “ ~ Rmerlin

“ Gnuton is already forked from my code. While I do the primary code merge + development, he gets his model-specific GPLs from Asus, and handles the merge of these model's binary blobs himself. He handles development and distribution for his models, as the point there is for me not to have to devote any of my own time to these models.” ~ Rmerlin

In other word gnuton still has to build every specific gnuton build himself from Asus’s GPL. Where Rmerlin comes in is front end stuff that’s Merlin related maybe some patches for specific upstream entware that’s built into each build eg. busybox. Where bugs come into play for gnuton is he has to handle each routers build and development. If something doesn’t get merged into the build eg. cake-QoS that’s specifically added into Merlin then it just won’t work. It’s a lot to deal with I imagine, and well I’m sure he and Rmerlin have discussions they aren’t the same person so well I’m sure he does his best to review changes in the master branch code from Rmerlin; each specific model and each new model added is a new learning curve.

This is just my take. If gnuton would like to chime in on anything I said that’s fine. Appreciate the support he gives.

gnuton commented 2 months ago

Hi @ajay-gh, the trust should come from the the code and not from my words in a gitub comment. Please do not open issue for complains, but rather use the chat or you will get banned.

Killswitch has been implemented 3 weeks ago by Eric and the fatures has been now backported to my fork too https://github.com/gnuton/asuswrt-merlin.ng/commit/1e4030ed7010c3758311cc3844f3bb7b10a4dc31

ajay-gh commented 2 months ago

Thanks for your response NV3771. And to merciless GNUTON, if you think that a report saying "Hope you don't mind explaining. Such an explanation helps building trust when using a "custom version" (more or less unknown) of a "brand name" like Merlin. Please do not misunderstand, this is not a complaint. Your work is valuable and appreciated, but in some cases trust is vital and all a user can have." is a complaint, and needs to be answered with "you get banned", then my friend

Nullvoid3771 commented 2 months ago

Thanks for your response NV3771. And to merciless GNUTON, if you think that a report saying "Hope you don't mind explaining. Such an explanation helps building trust when using a "custom version" (more or less unknown) of a "brand name" like Merlin. Please do not misunderstand, this is not a complaint. Your work is valuable and appreciated, but in some cases trust is vital and all a user can have." is a complaint, and needs to be answered with "you get banned", then my friend

  • there is a serious language problem (or ego problem) on your side
  • and I am all to happy to get banned. Enjoy !!

Try not to take offence he’s just meaning to use the https://www.snbforums.com/ or Gnuton’s Discord https://discord.gg/FArMTBN3

It’s where he and community members can answer questions, concerns, etc. GitHub is for developers, and bug reports, people that will take the time to debug a problem. It’s like instead of using front line support you show up at the developers house. Maybe not quite. But theirs better places for certain things.

Hope that helps.