matches now support Regexp objects

go-check / check

Rich testing for the Go language

Other

696 stars 182 forks source link

Open Lucretiel opened 7 years ago

Lucretiel commented 7 years ago

The matches function now supports Regexp objects, in case users want to only compile the regex once, before the tests run.

Also modified the function to use type switches, making the logic easier to follow

Lucretiel commented 7 years ago

Anything? This came up for me today. Not high priority, but would be convenient.

ashb commented 6 years ago

This would fix #94

niemeyer commented 6 years ago

It's a bit ironic to say that in a testing project, but we need tests. :)

ashb commented 6 years ago

I think it makes perfect sense -- if your test library isn't tested, how can you be sure it works?

It's tests all the way down!

Lucretiel commented 6 years ago

D'oh. I'll take care of it tonight!

Lucretiel commented 6 years ago

Tests added, though I'd appreciate a manual review to make sure I didn't typo anything

Lucretiel commented 6 years ago

Bump? Anything else needed before merge?