go-gitea / gitea

Git with a cup of tea! Painless self-hosted all-in-one software development service, including Git hosting, code review, team collaboration, package registry and CI/CD
https://gitea.com
MIT License
44.29k stars 5.43k forks source link

500 on PR list: wrong number of args for IsWorkInProgress: want 1 got 0 #29886

Closed sebthom closed 6 months ago

sebthom commented 6 months ago

Description

In the pinned issue https://github.com/go-gitea/gitea/issues/29773 the advice is given to use the nightly 1.21 build, however while this fixes one issue, it now breaks the list of PRs of repos and fails to render with:

An error occurred:

Render failed, failed to render template: repo/issue/list, error: template error: builtin(bindata):shared/issueicon:10:37 : executing "shared/issueicon" at <.PullRequest.IsWorkInProgress>: wrong number of args for IsWorkInProgress: want 1 got 0
----------------------------------------------------------------------
            {{if and .PullRequest .PullRequest.IsWorkInProgress ctx}}
                                              ^
----------------------------------------------------------------------

Gitea Version

1.21-nightly (1.21.8+17-g00ea9af8e)

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

image

Git Version

No response

Operating System

Debian / Dockerized

How are you running Gitea?

Self hosted

Database

SQLite

silverwind commented 6 months ago

Right, that's a separate bug. I'm suprised that no test had caught it.