code readability , small improvement for limit clause code

go-gorm / gorm

The fantastic ORM library for Golang, aims to be developer friendly

MIT License

36.8k stars 3.93k forks source link

I would like to suggest the following small change in clause/limit.go file regarding code readability the type Limit is described the following way
```
type Limit struct {
Limit  *int
Offset int
}
```
this is extremely confusing for someone reading the code the field named Limit inside of Limit type
can we change it to something like "MaxRows" , "LimitValue" e.t.c , that would make it very readable

and secondly (i am not sure about this one , open to suggestions) the following code has redundancy that it is making the same checks twice , can't we improve this , by reducing the redundancy?


// Build build where clause
func (limit Limit) Build(builder Builder) {
if limit.Limit != nil && *limit.Limit >= 0 {
    builder.WriteString("LIMIT ")
    builder.WriteString(strconv.Itoa(*limit.Limit))
}
if limit.Offset > 0 {
    if limit.Limit != nil && *limit.Limit >= 0 {
        builder.WriteByte(' ')
    }
    builder.WriteString("OFFSET ")
    builder.WriteString(strconv.Itoa(limit.Offset))
}
}

go-gorm / gorm

code readability , small improvement for limit clause code #7243