meyer9 commented 5 years ago

If you call proc.Terminate() in an external function, sometimes the VM will expect a return value on the stack even though there isn't one there because the function didn't finish. In this case, we should ignore the return value from the function.

codecov-io commented 5 years ago

Codecov Report

Merging #166 into master will not change coverage. The diff coverage is 100%.

@@           Coverage Diff           @@
##           master     #166   +/-   ##
=======================================
  Coverage   69.72%   69.72%           
=======================================
  Files          43       43           
  Lines        5010     5010           
=======================================
  Hits         3493     3493           
  Misses       1221     1221           
  Partials      296      296

Impacted Files	Coverage Δ
exec/vm.go	`83.27% <100%> (ø)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update cbbdf08...8fe30ca. Read the comment docs.

sbinet commented 5 years ago

Thanks for the PR. Could you send another one against the go-interpreter/license repo adding yourself to the authors& contributors files? Then I'll merge everything.

Thanks.

sbinet commented 5 years ago

Ping?

meyer9 commented 4 years ago

Doing that now, sorry missed your comment.

sbinet commented 4 years ago

thanks :) (and no worries)

go-interpreter / wagon

Fixes panic on terminate for return values #166

Codecov Report