search

go-piv / piv-go

Keys and certificates for YubiKeys, written in Go
Apache License 2.0
366 stars 65 forks source link

adding Shared access to multiple processes #100

Open rajnikant12345 opened 3 years ago

rajnikant12345 commented 3 years ago

Related: https://github.com/go-piv/piv-go/issues/47

ericchiang commented 3 years ago

@rajnikant12345 would you like me to take over this one?

rajnikant12345 commented 3 years ago

@rajnikant12345 would you like me to take over this one?

Yes that would be great, because this issue is moved to November on my side.

Thanks a lot

rajnikant12345 commented 3 years ago

@ericchiang , sorry for late checkin. I was busy with other related stories. I created a pull request.Please review. Whenever you get time. Thanks

rajnikant12345 commented 3 years ago

@ericchiang is this already checked in from your side?

Thanks Rajni

ericchiang commented 3 years ago

Thanks for the follow up! Sorry for the delay, but please ping if you need me to run the CI

rajnikant12345 commented 3 years ago

Thanks @ericchiang for reviewing I was busy with my new born 👶🏻, so got a bit delayed. I tried fixing your review comments, please have a look. we can run CI as well. Thanks

rajnikant12345 commented 2 years ago

@ericchiang anything needed from my side on this?

ezekiel commented 2 years ago

I see there are now some conflicts on the branch - if conflicts were resolved, could this be tested again and potentially merged?