Build failure on arm FreeBSD

go-piv / piv-go

Keys and certificates for YubiKeys, written in Go

Apache License 2.0

366 stars 65 forks source link

Build failure on arm FreeBSD #104

Closed clausecker closed 2 years ago

clausecker commented 2 years ago

The build fails as follows on arm FreeBSD:

# github.com/go-piv/piv-go/piv
vendor/github.com/go-piv/piv-go/piv/pcsc_freebsd.go:29:15: 0x8010002E (untyped int constant 2148532270) overflows int32
golang.org/x/crypto/ssh/agent
*** Error code 2

Please check and possible add a cast to make the number negative.

ericchiang commented 2 years ago

I don't have access to a FreeBSD environment so I'm not able to test any changes. If someone who does have one wants to send a PR and run the tests locally, I'm happy to review

clausecker commented 2 years ago

Sure, let me prepare something for you.