Add basic .gitignore and update error messages and add new messages.

go-piv / piv-go

Keys and certificates for YubiKeys, written in Go

Apache License 2.0

366 stars 65 forks source link

Add basic .gitignore and update error messages and add new messages. #137

Closed areese closed 8 months ago

areese commented 9 months ago

This pr adds a very basic .gitignore and adds error messages for move of the errors you can see out of the yubikeys.

areese commented 9 months ago

Are you actually hitting these errors? I would imagine that error messages like "Wrong parameters P1-P2" aren't very useful. At that point, should we just print the error code?

I've hit them while building gpg support. These errors go hand in hand with dumping the apdu's.

Most people won't hit them, but if you are adding things like attestation certs, or other functionality, you'll hit these a lot and they end up being more useful.