search

go-python / gopy

gopy generates a CPython extension module from a go package.
BSD 3-Clause "New" or "Revised" License
2.05k stars 113 forks source link

add no-warn flag; use underlying type for Named types for struct fields; use overall package name for DecRef etc. #222

Closed rcoreilly closed 4 years ago

rcoreilly commented 4 years ago

Fixes issues #219 #220 and #221

sbinet commented 4 years ago

LGTM.

thanks.

rcoreilly commented 4 years ago

I'm no git expert, so google told me to do this: https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/syncing-a-fork -- I just tried replacing "merge" with rebase and it got stuck with conflicts rather quickly...

I will plan to just delete the original fork and start over with a new fork for the next time. I looked at the diffs and they are correct so it should work.

I don't have time right now to do more with this so could you please just apply this PR and tests can be written later -- I'm preparing to teach online starting on Monday and this is part of the software I need to have available for my students, and I have a lot of other stuff to get done before then. Thanks!

cosnicolaou commented 4 years ago

I can write the tests, just file an issue against me and I’ll take care of it!

Cheers, Cos.

On Wed, Mar 25, 2020 at 10:30 PM rcoreilly notifications@github.com wrote:

I'm no git expert, so google told me to do this: https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/syncing-a-fork -- I just tried replacing "merge" with rebase and it got stuck with conflicts rather quickly...

I will plan to just delete the original fork and start over with a new fork for the next time. I looked at the diffs and they are correct so it should work.

I don't have time right now to do more with this so could you please just apply this PR and tests can be written later -- I'm preparing to teach online starting on Monday and this is part of the software I need to have available for my students, and I have a lot of other stuff to get done before then. Thanks!

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/go-python/gopy/pull/222#issuecomment-604237922, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACCMUYFDPCKCH6JNPQESJHTRJLR7XANCNFSM4LSHXUMQ .

sbinet commented 4 years ago

closing this in favor of #224