go-python / gopy

gopy generates a CPython extension module from a go package.
BSD 3-Clause "New" or "Revised" License
2.05k stars 113 forks source link

fix: Add build tags to loadPackage #293

Closed kevjumba closed 2 years ago

kevjumba commented 2 years ago

If buildFirst flag is set when loading packages, makes sure that the build flags are imported correctly to prevent intermediate errors like these:

Screen Shot 2022-07-14 at 2 21 43 PM

Issue is resolved later when package is actually built but we're missing build tags beforehand.

kevjumba commented 2 years ago

Quick fix: PTAL @rcoreilly Thanks!

kevjumba commented 2 years ago

@rcoreilly Please take a look at this if you have time!

rcoreilly commented 2 years ago

all looks good and apologies for the long delay!