go-spatial / geom

Geometry interfaces to help drive interoperability within the Go geospatial community
MIT License
168 stars 37 forks source link

Enable modules and remove vendor directory #97

Closed ear7h closed 4 years ago

ear7h commented 4 years ago

This was pretty straight forward but there is one issue of vendoring the ci tools. This was something we did before but, if we want to vendor them (and track versions etc.) we also need to vendor the the normal dependencies, which we did not do before. If we want the same behavior as before, I think we should "vendor" the tools in the same way as rtreego. Please advise.

coveralls commented 4 years ago

Pull Request Test Coverage Report for Build 442


Files with Coverage Reduction New Missed Lines %
planar/triangulate/delaunay/subdivision/subdivision.go 1 45.71%
<!-- Total: 1 -->
Totals Coverage Status
Change from base Build 440: -2.5%
Covered Lines: 5819
Relevant Lines: 10515

💛 - Coveralls
gdey commented 4 years ago

It looks like go mod will track the version's of the ci tools we are using. As long as we make sure to add them to the /internal/tools/tools.go file.

So, I think we are good on that part.