search

go-zookeeper / zk

Native ZooKeeper client for Go
BSD 3-Clause "New" or "Revised" License
504 stars 130 forks source link

break out tests that run a java zk cluster #113

Closed jeffbean closed 11 months ago

jeffbean commented 1 year ago

The tests that spin up a zookeeper cluster for testing are flaky in nature. They provide a great verification of behavior but are not isolated to Go.

This leaves the tests in a state where they flake for various reasons outside of the control of the Go runtime.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: -0.42% :warning:

Comparison is base (9ea55d9) 76.36% compared to head (c85e13d) 75.94%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #113 +/- ## ========================================== - Coverage 76.36% 75.94% -0.42% ========================================== Files 7 7 Lines 1193 1193 ========================================== - Hits 911 906 -5 - Misses 193 196 +3 - Partials 89 91 +2 ``` [see 1 file with indirect coverage changes](https://app.codecov.io/gh/go-zookeeper/zk/pull/113/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=go-zookeeper)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.