Add hints to remove cache manually in production environment. Fix #8

ncrypthic commented 8 years ago

Fix #8, update style

TheCelavi commented 7 years ago

I don't know why this PR is not still resolved, but here is my 2 cents:

This issue in general is familiar to Symfony devs, this state (dirty cache) can happen with any bundle, any service, not only to Aop Bundle
Exception witch you are catching and throwing is ambiguous, ServiceNotFoundException can for real be the proper exception that is thrown because there is no goaop.aspect.container service defined in container due to bad configuration. Converting it to RuntimeException with given error message could make user think that error is somewhere where it is not.

Your workaround is appropriate - we all do the same when we stumble upon similar situation (and that happens often when developing).

Since it is 1 year old PR, and it is known issue in regards to SF applications and bundles, I will have to close this PR without merging, sorry.

If you believe that this ought to be implemented, could you please provide some kind of method that will really, unambiguously, detect the state when cache is broken?

TheCelavi commented 7 years ago

@ncrypthic By the way - thank you for your PR, appreciated either way. Your bug report will help someone when googling/searching for same issue.

goaop / goaop-symfony-bundle

Add hints to remove cache manually in production environment. Fix #8 #10