gobuffalo / buffalo

Rapid Web Development w/ Go
http://gobuffalo.io
MIT License
8.07k stars 573 forks source link

add support for vgo #981

Closed sbinet closed 6 years ago

sbinet commented 6 years ago

it would be great (I think) if buffalo had support for (or started to investigate supporting) vgo.

right now, in a fresh GOPATH:

$> go get -u github.com/gobuffalo/buffalo/buffalo
$> cd $GOPATH/github.com/gobuffalo/buffalo
$> touch go.mod
$> vgo build -v
vgo: resolving import "github.com/dustin/go-humanize"
vgo: finding github.com/dustin/go-humanize (latest)
vgo: adding github.com/dustin/go-humanize v0.0.0-20171111073723-bb3d318650d4
vgo: resolving import "github.com/fatih/color"
vgo: finding github.com/fatih/color (latest)
vgo: adding github.com/fatih/color v1.6.0
vgo: resolving import "github.com/gobuffalo/pop/nulls"
vgo: finding github.com/gobuffalo/pop (latest)
vgo: adding github.com/gobuffalo/pop v0.0.0-20180320182557-d620a9477954
vgo: resolving import "github.com/gobuffalo/x/httpx"
vgo: finding github.com/gobuffalo/x (latest)
vgo: adding github.com/gobuffalo/x v0.0.0-20180117215853-11ca13c05abd
vgo: resolving import "github.com/monoculum/formam"
vgo: finding github.com/monoculum/formam (latest)
vgo: adding github.com/monoculum/formam v1.0
vgo: resolving import "github.com/pkg/errors"
vgo: finding github.com/pkg/errors (latest)
vgo: adding github.com/pkg/errors v0.8.0
vgo: resolving import "github.com/gobuffalo/packr"
vgo: finding github.com/gobuffalo/packr (latest)
vgo: adding github.com/gobuffalo/packr v1.10.6
vgo: resolving import "github.com/gobuffalo/plush"
vgo: finding github.com/gobuffalo/plush (latest)
vgo: adding github.com/gobuffalo/plush v1.0.0
vgo: resolving import "github.com/gobuffalo/tags"
vgo: finding github.com/gobuffalo/tags (latest)
vgo: adding github.com/gobuffalo/tags v1.9.6
vgo: resolving import "github.com/markbates/inflect"
vgo: finding github.com/markbates/inflect (latest)
vgo: adding github.com/markbates/inflect v0.0.0-20180314215004-b5c853d089b8
vgo: resolving import "github.com/russross/blackfriday"
vgo: finding github.com/russross/blackfriday (latest)
vgo: adding github.com/russross/blackfriday v1.5.1
vgo: resolving import "github.com/shurcooL/github_flavored_markdown"
vgo: finding github.com/shurcooL/github_flavored_markdown (latest)
vgo: adding github.com/shurcooL/github_flavored_markdown v0.0.0-20171120162553-28433ea3fc83
vgo: resolving import "github.com/sirupsen/logrus"
vgo: finding github.com/sirupsen/logrus (latest)
vgo: adding github.com/sirupsen/logrus v1.0.5
vgo: resolving import "github.com/gobuffalo/envy"
vgo: finding github.com/gobuffalo/envy (latest)
vgo: adding github.com/gobuffalo/envy v1.6.1
vgo: resolving import "github.com/gorilla/context"
vgo: finding github.com/gorilla/context (latest)
vgo: adding github.com/gorilla/context v1.1
vgo: resolving import "github.com/gorilla/mux"
vgo: finding github.com/gorilla/mux (latest)
vgo: adding github.com/gorilla/mux v1.6.1
vgo: resolving import "github.com/gorilla/sessions"
vgo: finding github.com/gorilla/sessions (latest)
vgo: adding github.com/gorilla/sessions v1.1
vgo: resolving import "github.com/gorilla/websocket"
vgo: finding github.com/gorilla/websocket (latest)
vgo: adding github.com/gorilla/websocket v1.2.0
vgo: resolving import "github.com/markbates/going/defaults"
vgo: finding github.com/markbates/going (latest)
vgo: adding github.com/markbates/going v0.0.0-20170113214412-0576708c56ce
vgo: resolving import "github.com/markbates/grift/grift"
vgo: finding github.com/markbates/grift (latest)
vgo: adding github.com/markbates/grift v0.0.0-20180319170132-76f93617a788
vgo: resolving import "github.com/markbates/refresh/refresh/web"
vgo: finding github.com/markbates/refresh (latest)
vgo: adding github.com/markbates/refresh v1.4.0
vgo: resolving import "github.com/markbates/sigtx"
vgo: finding github.com/markbates/sigtx (latest)
vgo: adding github.com/markbates/sigtx v1.0.0
vgo: resolving import "golang.org/x/crypto/bcrypt"
vgo: finding golang.org/x/crypto (latest)
vgo: adding golang.org/x/crypto v0.0.0-20180320225959-80db560fac1f
vgo: finding golang.org/x/crypto v0.0.0-20180320225959-80db560fac1f
vgo: finding github.com/markbates/sigtx v1.0.0
vgo: finding github.com/markbates/refresh v1.4.0
vgo: finding github.com/markbates/grift v0.0.0-20180319170132-76f93617a788
vgo: finding github.com/markbates/going v0.0.0-20170113214412-0576708c56ce
vgo: finding github.com/gorilla/websocket v1.2.0
vgo: finding github.com/gorilla/sessions v1.1
vgo: finding github.com/gorilla/mux v1.6.1
vgo: finding github.com/gorilla/context v1.1
vgo: finding github.com/gobuffalo/envy v1.6.1
vgo: finding github.com/sirupsen/logrus v1.0.5
vgo: finding github.com/shurcooL/github_flavored_markdown v0.0.0-20171120162553-28433ea3fc83
vgo: finding github.com/russross/blackfriday v1.5.1
vgo: finding github.com/markbates/inflect v0.0.0-20180314215004-b5c853d089b8
vgo: finding github.com/gobuffalo/tags v1.9.6
vgo: finding github.com/gobuffalo/plush v1.0.0
vgo: finding github.com/gobuffalo/packr v1.10.6
vgo: finding github.com/pkg/errors v0.8.0
vgo: finding github.com/monoculum/formam v1.0
vgo: finding github.com/gobuffalo/x v0.0.0-20180117215853-11ca13c05abd
vgo: finding github.com/gobuffalo/pop v0.0.0-20180320182557-d620a9477954
vgo: finding github.com/fatih/color v1.6.0
vgo: finding golang.org/x/sys v0.0.0-20180202135801-37707fdb30a5
vgo: finding github.com/mattn/go-isatty v0.0.3
vgo: finding github.com/mattn/go-colorable v0.0.9
vgo: finding github.com/dustin/go-humanize v0.0.0-20171111073723-bb3d318650d4
vgo: finding github.com/gobuffalo/pop v0.0.0-20180320182557-d620a9477954
vgo: parsing downloaded go.mod: go.mod:14: invalid module: github.com/gobuffalo/uuid should be v1, not v2 (v2.0.0)
go.mod:15: invalid module: github.com/gobuffalo/validate should be v1, not v2 (v2.0.0)
markbates commented 6 years ago

Currently vgo doesn’t support buffalo. As soon as they fix the issues with it, we will absolutely start working it in.

sbinet commented 6 years ago

Good to know. Could you point at those issues?

arschles commented 6 years ago

@sbinet we're also looking at this in https://github.com/gomods/athens/issues/73 - cross referencing in here so we can share what we find!

andradei commented 6 years ago

Is this still the case after the conversion on #1075?

stanislas-m commented 6 years ago

@andradei Yes, this is still the case: https://github.com/gobuffalo/buffalo/issues/1075#issuecomment-407440032

I'm closing this issue, since it's a dup of #1075.