gobuffalo / cli

The Buffalo CLI
19 stars 24 forks source link

Task improving test #247

Closed paganotoni closed 1 year ago

paganotoni commented 2 years ago

What is being done in this PR?

This PR rewrites our test command and adds tests for the cases that it used to cover. It also adds some helpful instructions needed to understand some of the flags that have been there forever. While on it I changed the way we determine the packages that need to be tested.

This is related to #241.

What are the main choices made to get to this solution?

Decided to simplify it and stick as close as possible to undocumented behaviors in the past implementation.

What was discovered while working on it? (Optional)

Learned how the Buffalo test command uses the -testify.m flag and found it a bit conflicting with the -run flag.

List the manual test cases you've covered before sending this PR:

I ran this command against a sample application and validated that it was causing the correct commands being run.

paganotoni commented 2 years ago

@sio4 I would love to get your blessing before merging this one. Whenever you have the chance please take a look at it.

sio4 commented 2 years ago

@sio4 I would love to get your blessing before merging this one. Whenever you have the chance please take a look at it.

Sorry for the late response. I was not able to take a look at this PR during the weekdays, but I will check it soon!

sio4 commented 1 year ago

Hi @paganotoni,

I had time to check this PR and also some background histories and tests for the issue and I left some comments on the issue #241. Please check those comments, I tried to describe in detail what I think about the issue and the underlying consideration for the command line style.

github-actions[bot] commented 1 year ago

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment. Otherwise, this will be closed in 7 days.

github-actions[bot] commented 1 year ago

This PR was closed because it has been stalled for 45+7 days with no activity.