search

goccmack / gocc

Parser / Scanner Generator
Other
622 stars 48 forks source link

gocc: Remove copyright notice from generated files. #45

Closed mewmew closed 7 years ago

mewmew commented 7 years ago

Fixes #44.

awalterschulze commented 7 years ago

I think you just need to regenerate, but then I approve.

mewmew commented 7 years ago

I think you just need to regenerate, but then I approve.

Regenerated.

mewmew commented 7 years ago

And thanks Walter! I'm impressed by your response time :)

mewmew commented 7 years ago

I love that you have added a Travis check to diff the output using "make regenerate". Forgot you had implemented that CI feature a while back. Very glad to see it in action!

awalterschulze commented 7 years ago

Well response time is because I am at home trying to do some haskell parsec :) I approve. You can merge this. I love automated builds approvals for pull requests.

mewmew commented 7 years ago

haskell parsec

Oh, lovely!!

Haha, now I feel jealous. I do believe the Haskell type system was meant for writing ASTs and the like, while in Go, you have to jump through hoops to make it behave.

awalterschulze commented 7 years ago

Yes well with Parsec you have to constantly think about LL(1) or other lookahead. Its not ideal, but pretty cool for building the ast. I still prefer gocc, but gocc could be faster if the go type system was less naive and gocc didn't have to do type assertions the whole time.