goccy / go-json

Fast JSON encoder/decoder compatible with encoding/json for Go
MIT License
3.13k stars 148 forks source link

fix: decode struct with pointer must be nil #473

Closed misyuari closed 1 year ago

misyuari commented 1 year ago

fix #472

misyuari commented 1 year ago

any comment? @goccy

goccy commented 1 year ago

Thank you for your contribution ! The changes are LGTM 👍 lint job is failing, please merge master once.

misyuari commented 1 year ago

Thank you for your contribution ! The changes are LGTM 👍 lint job is failing, please merge master once.

done 🚀

codecov-commenter commented 1 year ago

Codecov Report

Merging #473 (029656a) into master (3d5ab28) will increase coverage by 0.00%. The diff coverage is 100.00%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #473 +/- ## ======================================= Coverage 76.78% 76.78% ======================================= Files 55 55 Lines 18921 18922 +1 ======================================= + Hits 14528 14529 +1 Misses 3759 3759 Partials 634 634 ```
goccy commented 1 year ago

Thank you !! Merged.