search

goccy / go-zetasqlite

A database driver library that interprets ZetaSQL queries and runs them using SQLite3
MIT License
57 stars 30 forks source link

[String] Do not cast integer/float-like strings to datetime #184

Closed ohaibbq closed 8 months ago

ohaibbq commented 9 months ago

Closes #175

codecov-commenter commented 9 months ago

Codecov Report

Merging #184 (635786c) into main (961ce06) will increase coverage by 0.09%. The diff coverage is n/a.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #184 +/- ## ========================================== + Coverage 46.39% 46.48% +0.09% ========================================== Files 47 47 Lines 17828 17820 -8 ========================================== + Hits 8271 8284 +13 + Misses 8111 8092 -19 + Partials 1446 1444 -2 ```
ohaibbq commented 9 months ago

This will also require a change in bigquery-emulator repository.go to handle parsing of timestamps when adding table data

ohaibbq commented 8 months ago

The bigquery-emulator change has been merged to our fork here- https://github.com/Recidiviz/bigquery-emulator/pull/7/files

There's conflicts with the upstream repo until goccy/bigquery-emulator#271 is merged.

goccy commented 8 months ago

Thank you for your contribution ! LGTM 👍