goccy / go-zetasqlite

A database driver library that interprets ZetaSQL queries and runs them using SQLite3
MIT License
57 stars 30 forks source link

Enable `QUALIFY` without `GROUP BY` / `WHERE` / `HAVING` #201

Closed ohaibbq closed 7 months ago

ohaibbq commented 8 months ago

Closes #123

codecov-commenter commented 8 months ago

Codecov Report

Merging #201 (0557eea) into main (745096f) will increase coverage by 0.05%. Report is 1 commits behind head on main. The diff coverage is 55.00%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #201 +/- ## ========================================== + Coverage 47.82% 47.87% +0.05% ========================================== Files 47 47 Lines 17923 17930 +7 ========================================== + Hits 8571 8584 +13 + Misses 7910 7907 -3 + Partials 1442 1439 -3 ```
ohaibbq commented 7 months ago

@goccy I've updated the variable scope

goccy commented 7 months ago

Thank you !!! LGTM 👍