godarklight / DarkMultiPlayer

DarkMultiPlayer - A multiplayer mod for Kerbal Space Program
MIT License
282 stars 120 forks source link

Add SRCDS-style RCON implementation #444

Closed Technoguyfication closed 3 years ago

Technoguyfication commented 6 years ago

Hi! I just started using this server to play with my friends and I love this project! I thought it would be very useful to have a way to control my server remotely in case I'm not able to access the machine my server is running on. To solve this, I implemented SRCDS-styled RCON (Remote Console). It's the most widely used protocol for game servers and has many clients that support it. One popular client can be found here.

It integrates almost seamlessly with the existing command handlers and comes disabled by default. It starts a new TcpListener on a new port (6703 by default) and allows server admins to control the server from virtually anywhere. As the most popular multiplayer mod for KSP, I believe having a solid RCON implementation for the server is essential.

I hope you consider my addition, and I'd love to answer any questions you may have.

Xinayder commented 6 years ago

It looks nice but I have a few questions to ask:

Technoguyfication commented 6 years ago

Thanks for taking a look at my code, to address your concerns:

Technoguyfication commented 6 years ago

I moved the extension methods to the server project and cleaned up the code. Did you have any other questions/concerns?