godotengine / godot-cpp

C++ bindings for the Godot script API
MIT License
1.7k stars 528 forks source link

Change cmake required to v3.13 #1417

Closed ytnuf closed 6 months ago

ytnuf commented 6 months ago

This is because target_link_options was added in v3.13 So this wouldn't build with cmake v3.12

https://cmake.org/cmake/help/latest/release/3.13.html#commands

Likewise in CMAKE_CXX_STANDARD only supports value of 17 starting with cmake v3.9 So the test wouldn't build properly with cmake v3.6

dsnopek commented 6 months ago

Thanks!

dsnopek commented 5 months ago

Cherry-picked for 4.1 in PR https://github.com/godotengine/godot-cpp/pull/1411

dsnopek commented 5 months ago

Cherry-picked for 4.2 in PR https://github.com/godotengine/godot-cpp/pull/1410