search

godotengine / godot-git-plugin

Git implementation of the VCS interface in Godot
MIT License
717 stars 75 forks source link

Utf8 fixes #190

Closed markeel closed 7 months ago

markeel commented 1 year ago

This changes the encoding of any string from libgit2 to be treated as UTF-8. The only down side of this fix is if someone was already using something like ASCII-8BIT, but that seems less likely than someone using UTF-8 but with characters that are multi-byte.

markeel commented 7 months ago

I submitted a pull request a year ago, and it still has to be reviewed. I basically forgot about it (and have been using my version of this plugin since then), How do we move this along?

Calinou commented 7 months ago

I submitted a pull request a year ago, and it still has to be reviewed. I basically forgot about it (and have been using my version of this plugin since then), How do we move this along?

Please rebase this against the latest master branch so this can be merged :slightly_smiling_face:

See Pull request workflow for instructions.

Calinou commented 7 months ago