search

godotengine / godot-vscode-plugin

Godot development tools for VSCode
MIT License
1.52k stars 149 forks source link

LSP server won't start for current official Godot Server builds #517

Open turbohz opened 10 months ago

turbohz commented 10 months ago

Godot version

3.6.beta3.official.21ab700f2

VS Code version

1.83.1

Godot Tools VS Code extension version

1.3.1 (master)

System information

Linux

Issue description

This issue is related to: https://github.com/godotengine/godot-vscode-plugin/issues/516

I found an issue with current Godot Server builds, which causes --version (also --help) command to return an error status code (255). This is caught by the plugin check for a valid Godot executable, which then refuses to start the LSP.

This is clearly an issue with Godot, and I will report it as such (if it's not a known issue).

Steps to reproduce

Download a current Godot Server build (platform is listed as "Linux Server").

Run it to obtain the version: Godot_v3.6-beta3_linux_headless.64 --version

You'll see the version printed. However, the status code will be error (255)

turbohz commented 10 months ago

Here's where the issue was introduced:

https://github.com/godotengine/godot/pull/62618

DaelonSuzuka commented 10 months ago

Thanks for tracking down the cause of this. I'll see if I can rearrange the version check to get around this false-negative.

turbohz commented 10 months ago

Thanks for tracking down the cause of this. I'll see if I can rearrange the version check to get around this false-negative.

I don't know if it's worth fixing. I don't expect many people to try to use the godot server build to run the LSP server, instead of the editor.

In any case, I submitted a fix and it's been approved (https://github.com/godotengine/godot/pull/83664).

turbohz commented 9 months ago

https://github.com/godotengine/godot/pull/83664 has been merged, so it seems this issue will be fixed in the next Godot 3.x release.