search

godotengine / godot

Godot Engine – Multi-platform 2D and 3D game engine
https://godotengine.org
MIT License
91.51k stars 21.26k forks source link

Visualscript connection lines get drawn over or below the nodes each time a node gets selected #11639

Open mrcdk opened 7 years ago

mrcdk commented 7 years ago

Operating system or device, Godot version, GPU Model and driver (if graphics related): Godot 3.0 master https://github.com/godotengine/godot/commit/da144fed4c49133a93b3b83cfc665352c0af351a

Issue description:

https://i.imgur.com/zJhmmrO.gifv

Steps to reproduce:

  1. Add nodes to a visualscript
  2. Make lines overlap nodes to better see the issue
  3. Start selecting different nodes (or the same sometimes)
  4. Lines get drawn over and below the overlapping node each time you select a node
akien-mga commented 6 years ago

We have now entered release freeze for Godot 3.0 and want to focus only on release critical issues for that milestone. Therefore, we're moving this issue to the 3.1 milestone, though a fix may be made available for a 3.0.x maintenance release after it has been tested in the master branch during 3.1 development. If you consider that this issue is critical enough to warrant blocking the 3.0 release until fixed, please comment so that we can assess it more in-depth.

akien-mga commented 5 years ago

Is this still reproducible in the current master branch?

mrcdk commented 5 years ago

Yes, still happening in https://github.com/godotengine/godot/commit/382f0991ee7ece2a99cfbdbf641d46777b8c8edf

https://i.imgur.com/GlUy5b2.gifv

akien-mga commented 3 years ago

I tried a bit in 3.3-stable and didn't manage to reproduce the issue, could you confirm if it's also fixed on your end?

I've been trying with the setup and all kinds of attempts at selecting different or the same nodes:

Screenshot_20210423_223717

mrcdk commented 3 years ago

Sadly it seems it's still happening on 3.3-stable.

NN71UuaU4q

The gif was recorded on Windows 10 GLES3

akien-mga commented 3 years ago

Now I can also reproduce it... not sure what I missed before.

Zylann commented 3 years ago

I have seen this happen in my own tools, this is a problem with GraphEdit. I believe connections are siblings of nodes and nodes get raised up/down the tree so sometimes it might mean some connections come later in the tree, causing them to draw on top?