Calinou
commented
2 years ago @JesusRoberto64 Can you reproduce this in any of the 3.5 betas and RCs to determine when the regression started?
Closed JesusRoberto64 closed 2 years ago
Calinou
commented
2 years ago @JesusRoberto64 Can you reproduce this in any of the 3.5 betas and RCs to determine when the regression started?
JesusRoberto64
commented
2 years ago @JesusRoberto64 Can you reproduce this in any of the 3.5 betas and RCs to determine when the regression started?
I tested in Beta 1 and it does not have that button issue, I tried in Beta 2 and the problem appeared. Then I tested on others upper than Beta 1 and RC versions, and all of them have the problem.
I hope it helps. Thanks for the attention.
madmiraal
commented
2 years ago I'm unable to reproduce either of the issues described.
@JesusRoberto64 please provide an MRP that reproduces the issues.
The attached MRP works fine with a PS3 controller's DPad. It tests both the is_action_pressed for the default InputMap ui_left, ui_right ui_up and ui_down actions and the Button focus_neighbor_left, focus_neighbor_right, focus_neighbor_top, focus_neighbor_bottom settings:
ActionTest.zip
As far as I can see the only change made to joypad input is: 949ea2b326 Simplify InputDefault::joy_axis code by using float instead of struct JoyAxis
The only changes made to action input is: 2232168ede [3.x] Fix action exact match
Neither of these are related to the issues described.
JesusRoberto64
commented
2 years ago I'm unable to reproduce either of the issues described.
@JesusRoberto64 please provide an MRP that reproduces the issues.
The attached MRP works fine with a PS3 controller's DPad. It tests both the
is_action_pressedfor the defaultInputMapui_left,ui_rightui_upandui_downactions and theButtonfocus_neighbor_left,focus_neighbor_right,focus_neighbor_top,focus_neighbor_bottomsettings: ActionTest.zip For the record, the commits between beta1 and beta2 are:62fa80a Cleanup internal GUI state, if event is accepted in _input. 2ff0735 Added primary clipboard for Linux 3d7821b Drop mouse focus and over when gui input is globally disabled c2c0c80 Add missing property name capitalizations 0ffacff [3.x] Add option to make selection unique 4167e98 Add drag and drop to TextEdit, LineEdit, RichTextLabel 5f9c13b Improve display of freelook/zoom speed indicator bars in the 3D editor 871a733 Fix crash when is-operator right-hand-side is null caf2c20 Don't store and show current file/directory/path FileDialog properties 846416a Copy full project setting path from dialog. f280712 Fix missing grid lines when TileMap has half offset 36ec71b Hide smart snapping line when guideline dragging ends c963364 Prevent non-smoothed face normals to participate to smoothed face normals c731cda Clarify the position of points in
Curve{2D,3D}.add_point()743f2d2 UseRTR()for VisualScriptNode captions and texts 93447eb Use get_cursor_shape for identifying the cursor shape in AnimationNodeStateMachineEditor e2bd1ad Use get_cursor_shape for identifying the cursor shape in AnimationTrackEditTypeAudio d924067 Use get_cursor_shape for identifying the cursor shape in AnimationTimelineEdit 15aab4c Remove unused code inAnimationPlayerEditor::_update_animation_list_icons()a17c6e5 Fix normals computation at the 'seam' of smoothed torus shape 3040285 Add offset string from minutes conversion method to Time singleton 0b650b3 Clear owners when pruning even out of the tree 7d219b6 Fix RichTextLabel shadow color when text has transparency bc924d4 Correct docs for Environment background keep mode 2fb998b Fix alpha scissor support 86ec09f Improve TileMap editor grid 2cafaf3 Fix documentation about depth and width of Height map cec7c90 Addget_screen_refresh_rate()to OS 622ef48 Fixed ccd enabled by default on Bullet bodies 5d7b3e1 Create parent directories on export. 3b04f59 Fix some Animation panel icons not updating after theme change c229721 Fix TextureRegion editor grid color for light themes 2c3646b Add missing i18n to various strings 5514126 Don't show Lock & Group buttons for nodes hidden by CanvasLayer 2ccd4fd Fix animation resource name after duplication a26afe8 Update audio effect icon when theme changes 8a6b066 Allow absolute file paths in file dialogs fa56990 [macOS and iOS export] Add localized application name to the translation .plist files. db9d426 Remove extra separator when TextEdit is read only and unselectable 86bcac5 Fix text color of TileMap editor info overlay a4088a9 Properly handleCSGShapeparent and visibility updates 94a5f9e Fix capitalization of boolean output in classref 6c56433 i18n: Sync classref translations with Weblate 751769e i18n: Sync editor translations with Weblate a73bd2d Revert "[HTML5] Fetch API now passes credentials." 690020d Revert "Fix ProjectSettings has_setting() when used on a overriden setting with feature tags" d13e127 Fix normals computation at the 'seam' of smoothed sphere and cylinder shapes 84a2730 Use ToolSelect icon for TileMap editor select button bee9a6c Fix add child error when opening the Editor c37be0f Expose TextEdit get_visible_rows() and get_total_visible_rows() to GDScript b76147e Fix top level CanvasItem visibility d0901d4 Revert backport of "Rework CanvasItem visibility propagation" ba0a17a Revert "Fix CanvasItem visibility propagation" 424dbf7 Increase VARIANT_ARG_MAX to 8 de79e10 [3.x] Add option to filter the stack variables of GDScript debugger 0bcda22 Protection for array operator for Vector2 / 3 in DEV builds 76df26b GLES2: Fix VersionKey comparison inShaderGLES2::bind()b28eea6 Fixed issue where Extend Script option would show up even without script attached to the node cc65147 Update scroll position when zooming TileSet editor 733a84f GLES2 Compression on Blend Shapes Fix 9988739 Fix shader state caching when blend shapes used 2e6a305 Improve display for unsupported debug draw modes in GLES2 61e35b4 Make name of editor file dialog filters translatable 0e8a76d Add icon_color_normal to Button in editor theme 9d6f4a7 Fix X11 memory leak after drag & drop file into the editor aaff2e3 i18n: Make property paths and sections translatable 2893090 Color 3D editor FPS label depending on the performance level 4136895 Always register the Smooth Trimesh Collision project setting f2166ba GDScript: Don't coerce default values to the export hint type c63ab66 Revert "PitchShift effect quality and performance tweaks for different pitch scale values" 56fd92c FixUndoRedo::create_action()invalid memory usage e3cd47f [iOS] Fix multitouch not working correctly 7e07d47 Fix AnimatedSprite infinite loop 824eaab Print every file exported withPCKPacker.flush()s verbose parameter e66003b Upgrade stb_rect_pack to 1.01 a1155b8 Fixed 0 width issue of rich text label Fixes #37746 8bbcc62 Fixed underlines and striketrough not respecting visible character c4041ca Added or improved documentation to a few more String methods 54eac2a Update doc for match: empty argument doesn't match anything e510287 Translate class brief description in Editor Feature Profile dialog 7b9a912 fix cubic interpolate when looping 3.x 4ec4b5a Portals - fix duplication of instanced scenes during conversion 322e3a9 Joint2D and Joint: make set_exclude_nodes_from_collision respect signals f197e5e Joint2D and Joint: update joint on NOTIFICATION_POST_ENTER_TREE 1348f86 Make string inside TTR() single-line 036bace BVH - Fix area-area collision regression 89ce63a AreaSW and Area2DSW: fix premature return in call_queries 688dc53 Fix get_global_transform_interpolated() with multiple ticks per frame d24c715 Float literals - fix math classes to allow 32 bit calculations 0959ff2 Add sanity checks to lightmap unwrap texel size 76de874 Update AUTHORS and DONORS list 310adf5 Add more information on triangulate polygon 595d67a Document glow rendering caveats when using GLES3 on mobile e3f8491 Fix GIProbe gizmo out of bounds crash 4c2ffa7 Fix test_shader_lang (for 3.x) 6475c67 CI: Use mono_static=yes for Mono builds cb108fb Portals - improve STATIC bounds on conversion 7e2c4aa Fix external textures not working correctly with viewport texture e6f1a44 In final phase of test_body_motion, move and cull AABB for body once instead of for every shape b90f1a3 Disable jitter fix when physics interpolation is enabled. fdded6b Fix 2D instance drop position 156d9d1 simplify calculation of max in grayscale 0d8fa9b Sync controller mappings DB with SDL2 community repo 642591b Fix CanvasItem visibility propagation 52ce161 [HTML5] Add Stadia controller to database 2e75471 Fix GLTF exporter crash when using GridMap 2c00b90 Fix deleting of directories on Linux 66085e2 Optimize String::copy_from(const CharType &p_char) 3d35f29 Optimize String::copy_from_unchecked 069e8f3 Optimize String::operator+= and CharString::operator+= 177041b Allow disabling the alpha trim on texture atlas creation. cfba65f ExposeAudioServer.capture_deviceas a property 60f9c0f Fix decompression functions not returning errcodes 92e6c2a Use versioned URL for "Online Documentation" buttons in the editor f61ce6e Fix wording in AnimationNode classref 4282076 [iOS] Fix incorrect method name for input dragging event def3589 Document that meshes and lights must be fully set up before baking GIProbe 85be83e Fix typo in CanvasItem visibility propagation backport 3b25190 Only store_edit_use_anchors_metadata if value is not the default d9c99f6 Improved region-select in the 3D editor viewport 67b879e Deselect nodes in the 3D editor when pressing ESC df13466 Add type variations to Theme ac0d37d Add a property hint for the Line2D Round Precision property d09a023 Translate link titles in classref XML c9f9e06 Fix documentation about TreeItem button ID 0f76143 Make VMap::find_nearest return -1 when empty 9135074 Fix VisualScript crash when using Set Index node 2ed43f9 Added show and hide methods and updated doc API. 8f14941 Fix mismatched BBCode tags in classref 9171737 Document Light contact shadows often looking broken 7f9e974 Add anOS.get_processor_name()method 0e9a9a7 Fix description of OccluderShapePolygon.two_way a91a24f Don't translate numbers in VersionControlEditorPlugin 5688ca6 Backport editor type icons 3c2df49 Fix Occluder to properly share resources 522bce1 Fixed Timestep Interpolation (3D) 9cb1695 i18n: Sync classref translations with Weblate 9f09251 i18n: Sync editor translations with Weblate b2c012a Add GridMap.get_used_cells_by_item 3dc0e97 Fix incorrect buffer upload size in GLES2 draw_gui_primitive 690f971 Add support for saving multiple Images in BakedLightmap 8b49a62 [3.x] Fix AnimationTrack mouse wheel zooming at low zoom level 7dcb25e Improve documentation for AudioServer device properties and methods 273abf5 Fixed variant decoding Segmentation Fault 51d028f Audio quality improvements in PitchShift 6471d0a Pass audio samples untouched for pitch_scale around 1.0f 5ca3a36 Clarify identicalhash()return values due to collisions 48f3237 [macOS] Add missing translation file. 695da68 Tweak logo max width on the web editor d0fba91 Allow using the web editor on any device orientation 9b71471 Hide Polygon2D lines and handles when node is not visible in tree. cb885e9 Hide CollisionShape2D handles when node is not visible in tree. b343660 has_setting now correctly returns true when the setting is present due to a feature tag a25137c Utilize mouse position when zooming with shortcuts in 2D editor ff06d09 NavMap Fix polygons being treated like triangle strips instead of triangle fans 0812835 Clamp environment light sky contribution to the [0.0; 1.0] range 53b9609 Improve completion scroll bar visibility in the script editor (3.x) 614dc36 Fix GL buffer upload size bugs aaf29c2 Make duplicate animation prompt for new name ff55157 Don't use prepass threshold with alpha scissor f1d289f Improve theAudioStreamPlayer2D/3D.area_maskdocumentation 8988a9b [HTML5] Fetch API now passes credentials. 7a16bb2 Fix typos with codespell 1865f06 Extract link titles for translation if available 115b653 i18n: Exclude$DOCS_URLlinks from classref translations 1747bec Fix GridMap memory leak e5fd6a5 Don't display empty Class Properties in feature profile 52e0613 Recommend using GitHub attachments for minimal reproduction projects 14a1303 [Net] Non-blocking WebSocket hostname resolution. 6d867b6 Make parser treat all exponent literals as float 61cd26b Added hex and bin literal support to Expression parser e4e3f7d Add a signal to notify when children nodes enter or exit tree ca43272 Fixed opening new instances of VS 2022 while a instance is already open 1afefea Add Visual Studio 2022 support with fallback to 2019 72e338e libwebp: Sync with upstream 1.2.2 ef0ec3f Add warning for Windows export when rcedit is not configured 49059e3 Expand description for warp_mouse_position method 6bcb24f Add empty translation files to the exported app bundle, to allow translation detection by the OS. 5378d13 [macOS] Add empty translation files to the editor app bundle, to allow translation detection by the OS. 12841d5 DOCS: Object.set() does nothing on type mismatch 8231303 Backport FlowContainer e793466 Tweak the Bullet RigidBody kinematic trimesh warning message f49ffe4 Backport CanvasLayer visibility f50c7f7 Core: Move generatedVERSION_HASHto a.cppfile a672f0d [3.x] Fix CanvasItemEditor scale editor not using the editor methods 6dbb67c SCons: Make compilation database generation optional ec12e24 SCons: Addfast_unsafeoption for faster rebuilds c27b05f use exact match when checking focus next / previous a3fe028 GDScript: Infer variable types on release f0af293 ProjectSettings add dirty flag and project_settings_changed signal b15ad8e Fix for S3TC on Android and IOS devices 134aac5 Fix Vector2 and Vector2i coord access via operator[] a3f6033 Improve TreeItem button API 74a4795 Fix RayCast{,2D}.clear_exceptions clears parent 1d3de16 Add alignment options to icons on buttons. 6f7cef6 Use ScriptServer::get_global_class_base instead of script_class_get_base in script_class_is_parent. 1b505ef Document performance limitations with CSG nodes, link to tutorial eddb99b Attach mono thread before getting nativeName field 87b4db9 SpriteFramesEditor Fix crash when selecting non-Texture file for splitting 4c23a90 [HTML5] Implement JavaScript PWA update callbacks. afdfe7c [HTML5] Improve editor progressive web app behavior. 73f3965 [HTML5] PWA service worker prefers cached version. f9fdd52 fix portal_occlusion_culler compilation with target=debug tools=no a4f0e02 Update definitions of get_mouse_position methods bf5b2f4 Re-fix Disabling Half Floats on iOS 0d1ec9a Improve ubershader compatibility ee979d3 Add fflush to error macros de47cb0 Fix PoolByteArray.decompress_dynamic return value and memleak f63bea9 Make popup menus focus items automatically when not using the mouse 10eb956 Portals - Improve mesh merging aeb9925 Revert "Fix ViewportPreview upside-down in 3.x." 4a52016 Revert "[HTML5] Better engine config parsing." aba5f6d [iOS] Fix touch handling for overlay views 94dd9c2 Server: Fix skip libstdc++ static linking on macOS 80306cc EditorProperty: Fix range hint parsing with optional step f44b7c3 Fix iOS export with manually specified signing/provisioning data. 90bea27 BVH - fix leaking leaves 9150fe5 Add documentation for StreamPeerBuffer 6c6e50b Fix navigation merge errors, fixes #56786 d86061d Portals - fix DYNAMIC particle systems 621cf7d Update the minimum size of ViewportContainer a0c6d16 Add editor vital redraws only option 7f00317 Clarify documentation for Rect2'shas_no_area()8ea20f5 Add OccluderShapePolygon 58edf04 Windows: Fix GCC -fpermissive error with 'pck' section workaround 3095dce [3.x] Backport Windows subsystem build option. 32d8305 TextureButton Fix logic for drawing only the focus texture aa3ef20 [Net] Simplify IP resolution code, fix caching. c25365d Be more verbose about why msbuild tools could not be found ba2e891 [Windows] Disable console I/O redirection, if it's already redirected to the pipe or file. 82c83a0 [HTML5] Fix gamepad samples not being properly reset. 6209eed [HTML5] Better engine config parsing. 0a77d2d Merge create_physical_skeleton undo entries. 423a900 Prevent LTCG (MSVC LTO) from removing "pck" section fa906f7 Fixes invalid links to tutorials in AudioStreamGenerator, AudioStreamGeneratorPlayback, and AudioEffectSpectrumAnalyzer class references 3fd186c Improve documentation forReflectionProbe.max_distanceproperty 83298da Backport improved look_at docs and errors a118837 Fix button icon_color_disabled alpha channel 4d8e6fd Fix transforms involved into navmesh baking c7f716e Mono/C#: Fix Android AAB export failing to load native libs 94ddd41 Simplify usage of OS::get_window_size() in SceneTree methods c6890c6 Fix "mass" and "weight" properties of the RigidBody (and RigidBody2D) in the Inspector view 5deeb38 Fix XR Android manifest metadata 584efcd Make WebXR touch events proportional to render target size, not viewport 797bb1d Ensure that NavMesh baking updates the inspector eb975b7 [Export, 3.x] Instead of removing unsupported options, hide it. f8afd16 Fix memory leak when move to trash fails on Linux 941879f Expose BitMap'sconvert_to_imageandresizemethods to GDScript 58191c4 Make sureMeshLibraryshape array has correct number of elements 7a7eab0 Fix crash after renaming an animation node 6340e4c Expose AnimationNodeOneShot::mix_mode as a property 2eb12f1 doc: Clarify expected type ofObject *parameters in Tree methods 4f1f76c Add local web server configuration designed for web editor development 822da98 [Net] Fix get_response_body_length for large files. dd57c32 Fix Array and Dictionary id() and dictionary test bug 5b240d8 SpriteFramesEditor Show AtlasTexture's source texture path in the frame's tooltip 164ef07 Update AssetLib network settings when Editor Settings change b531a49 Added the smart word wrap property to preview label b8a7a74 Tweak theme color to match the Godot editor's background color d3473b2 Rework Node::get_node to omit is_absolute() check in best case scenario 96a325d Force threads when compiling web editor instead of erroring out 38240fd Portals - Fix gameplay monitor ticking fa96505 Store ObjectID instead of raw pointer for Shape Owners 85deed9 Backport some changes to 3.x shaders 75fcb31 [3.x] Consider gridmap collisions in navigation bake 6ac800a Add clarification to tile_set_modulate 7df2f31 Use refval() instead of separate ref() and get() 6cecb22 Fix GDNative docs links 54de063 [3.x] Fix make_rst.py on Windows 36c7110 Fixed accessing a null MeshInstance object in BakedLightmap instead of the GeometryInstance 357e7e8 Use a fixed-width font for internal references in the editor help 67cf622 ImproveNavigation2Ddefault settings, fixes #56852 0af2628 Fix some errors in Environment documentation c29258e Update AUTHORS and DONORS list aa6465c Fix style error from previous merge 1e1fb14 Improve CSGPolygon3D documentation a5b9f9f [3.x] Fix Create Root Node dialog expanding in favorites tab 7dcfe6b Improve Groups dock panel and the Group Editor dc14636 BVH templated mask checks and generic NUM_TREES 6c1e243 Portals - fix gameplay monitor unloading 061ee6c Disable ScriptEditor's menu items when they do nothing 8948b36 Add project setting to change scene file casing 1c3d3af backported method get_rid for NavigationAgent 856f2d0 Add shortcuts for New Scene and New Inherited Scene actions adf14bf Add nodiscard to core math classes to catch c++ errors. f8f83f0 Fix RichTextLabel uninitialized content height value. 30ee208 [macOS export, 3.x] Implements ad-hoc signing on Linux/Windows, adds extra privacy settings, entitlements warnings and error checking. c540a17 Better explain JSON print indent parameter (3.x) 94b1ae5 Document that soft bodies should be avoided for gameplay purposes 752fbc7 Fix indexing of polygon points when building path. 9753fe7 Print a notice when compiling withtarget=debug742c54d Fix import hints breaking node paths in animations 684b7fd Fix "Convert to MeshLibrary" not respecting collision transforms 37910dd Allow selection of option 'Open in File Manager' even when a file/folder is not explicitly selected. 58c460b Removed redundant ClassDB::is_class_enabled() and moved second dynamic_cast inside worst case if 27fc50d Fixinput_ray_pickabledocumentation forCollisionObject3D3641ec6 Prevent renaming to an unkown extension from FileSystem dock. ccb52db Clarify to_float() and to_int() methods 7eb8339 [Documentation] Add instruction how to execute built-in commands of various shells. 0e5f063 Improve iOS icon / loading screen export. ac144e7 Fix invalid read when using LightOccluder2D 28ae995 Fix crash when undoing node creation of BlendTree editor 08af6e0 Replicate load-as-placeholder state on node duplication 986b99e Mention that modifying text erases BBCode stacks 7bd13a4 Automatically go up if current dir was deleted a36ca80 Improve the SnapGrid editor icon d479045 Fix marshaling values of generic Godot Dictionary 4f1e33b freetype: Update to upstream version 2.11.1 d76a26e Bump mbedTLS version to 2.28.0 (new LTS). 76297e7 AddOS.has_clipboard()to check clipboard content 342035b Fix ColorPresetButton's overbright indicator in default theme 8109902 stb_vorbis: Add clearer error messages when failing to import OGG file cab8912 Fixed a typo in BakedLightmap documentation 3654865 Improve Colorpicker presets 7f49e5b ExposeImage.COMPRESS_SOURCE_LAYEREDto scripting 1ee44b2 ImageLoader: Remove references to unsupported svgz extension a80187f Fix visible background line in intersections in screen-space reflections 64fcf7e Fix LineEdit center and right alignment 3b085e2 C#: Allow configuring Mono debugger agent with cmdline args e39f628 Fix touch events when using smartphone AR with WebXR 5bad077 Dont set elapsed to 0 when a tween is finished. 63fd172 Fix AtlasTexture nesting 36c3b87 Fixes shader compile due to undefined 'diffuse_color' variable with Oren Nayer + Vertex Lighting 8a42ab7 Fix crash wheniskeyword is tested against a String variable 949ea2b Simplify InputDefault::joy_axis code by using float instead of struct JoyAxis 2232168 [3.x] Fix action exact match 9d2070e Modify texture of selected tabs to better blend with the panel 6556442 Fix for RegEx.search() memory leak on Windows a627cda Update copyright statements to 2022 5831956 Unify theme item lookup in Controls and respect default font 21ca1c9 Fixed a number of ",or_greater" for the bug #56324 b754563 Use mouse event relative motion to calculate mouse speed b6f0460 Remove duplicated sentence in EditorVCSInterface classref 027a584 Document using SpriteBase3D'smodulateproperty with material override 22750b1 Replace String::find_last with rfind where possible (backward compatible with old API) 37a38ec Allow showing both left and right side panels 6093d59 Fix NavigationObstacle errors ae918c3 Use asynchronous shader compilation and cache in the editor if requested d00e183 Fix undo/redo operations in Input Map 3f94ea6 Fix detected leaks/heap-use-after-free by AddressSanitizer at startup b4ec1c5 Backport: Allow for mapping scancodes to current layout 74e8d5c Fix AnimationTree function call track loop 31ad990 Allow changing directional shadow size at run-timeAs far as I can see the only change made to joypad input is: 949ea2b Simplify InputDefault::joy_axis code by using float instead of struct JoyAxis
The only changes made to action input is: 2232168 [3.x] Fix action exact match
Neither of these are related to the issues described.
Hi, Thanks for the response. The issue appear on Generic Game pads(in PS3 controllers works fine). Here are links of the gamepads I used:
https://www.ele-gate.com/producto/control-joystick-juegos-pc-laptop-gamepad-usb/
https://www.amazon.com/Controller-Gamepad-Joystick-Gamestick-Raspberry/dp/B09ZTSV7QK?th=1
Both are from different manufacturer and company, the only thing in common is that they are retro style 2.0 usb port.
I tested in the project you provide and I have the same result. (Generic game pads don´t work). But for the doubts I share a project that I made with the same problem. CtrlsGenericTest.zip
Again Thanks for the attention.
madmiraal
commented
2 years ago @JesusRoberto64 Does this only happen with actions? Or, does it also happen when querying the button directly with Input.is_joy_button_pressed(device, button). To make it easier, do you see the DPad buttons sticking with the Joypads Demo: https://godotengine.org/asset-library/asset/140?
Also, please provide the GUIDs for your joypads? The long number displayed at the top of the Joypads Demo. i.e. the output of Input.get_joy_guid(device)
JesusRoberto64
commented
2 years ago @madmiraal Yes, the problem still happens in the Joypad Demo:
Here are de GUIDS for my joypads:
-Retro Controller 03000000790000001100000000000000
-NEXT SNES Controller 030000001008000001e5000000000000
madmiraal
commented
2 years ago @JesusRoberto64 I think I've found the source of the bug. Please confirm whether or no #64211 fixes the issue.
JesusRoberto64
commented
2 years ago @JesusRoberto64 I think I've found the source of the bug. Please confirm whether or no #64211 fixes the issue.
I compiled the #64211 , and the problem persists. Sorry if I take too much to answer.
madmiraal
commented
2 years ago @JesusRoberto64 Thanks for the feedback.
What is the output of Input.get_action_strength() for ui_up and ui_down, and ui_left and ui_right when pressing and releasing the DPad up and down, and left and right respectively?
| Action | ui_up | ui_down | Action | ui_left | ui_right | |
|---|---|---|---|---|---|---|
| Initial | Initial | |||||
| Dpad up pressed | Dpad left pressed | |||||
| Dpad up released | Dpad left released | |||||
| Dpad down pressed | Dpad right pressed | |||||
| Dpad down released | Dpad right released | |||||
| Dpad up pressed | Dpad left pressed | |||||
| Dpad up released | Dpad left released |
Also, with these controllers, is it only ever 0 and 1 or does it range between?
JesusRoberto64
commented
2 years ago The values that returns are only 1 or 0. I hope this can help.
madmiraal
commented
2 years ago Okay, I think I've now found the source of the bug. @JesusRoberto64 Please confirm that #64532 (the 3.x version of #64531) now fixes the issue.
JesusRoberto64
commented
2 years ago Okay, I think I've now found the source of the bug. @JesusRoberto64 Please confirm that #64532 (the 3.x version of #64531) now fixes the issue.
Yes, issue the was fixed. Now the joy-pads works normally :)
Thank you.
madmiraal
commented
2 years ago Great! Thanks for testing.
lucasthomaz97
commented
2 years ago the button A on my nintendo switch pro controller simply don't work here. i'm using a windows 10 pc and godot 3.5
Godot version
3.5
System information
Windows 10 OpenGL ES 3.0 Renderer: GeForce GT 710/PCIe/SSE2
Issue description
When I press the D-Pad Button(down and Right) from some controllers, the Input.is_action_pressed keep calling the action, even when I release the button, thought. That make the UI navigating using focus buttons don't work properly. And also my game pad(generic game pad) its not longer usable on my game. I tried with a PS3 controllers and it works fine when I press (down-Left pad). But I notice something strange, the action ui_focus_next and ui_focus_prev, does not work in Button-Control node, this happens in any game pad. If I put a print to see if there is a call for the Input.is_action_pressed, it its called but not detected by the Control-Button Node. I haven't any issues of this kind in previous Godot versions 3.4.4 and below.
Steps to reproduce
1.-In Project Setting - Input map put any action using Device-0 Button 15(D-Pad-Right) and/or Device-0 Button 13(D-Pad-Down)
2.- Put a script to the detect Input event EXAMPLE : func _process(delta): if Input.is_action_pressed("ui_right"): print("right UI ", randi()%100) pass
3.- And then see that the action is keep calling till the end of time, with the buttons unpressed or released.
Minimal reproduction project
No response