Error calling deferred method: 'EditorNode::EditorNode::restart_editor'

[brcontainer]

Tested versions

• Reproducible in:
  • v4.4.dev3.official [f4af8201b]
  • v4.4.dev4.official [36e6207bb]
  • v4.4.dev5.official [9e6098432]
• NOT reproducible in:
  • v4.3.stable.official [77dcf97d8]
  • v4.4.dev2.official [97ef3c837]

System information

Windows 10 - Godot v4.4-dev5 - Vulkan (Forward+) - dedicated NVIDIA GeForce GTX 1050ti

Issue description

When upgrading the meshes using Project > Tools > Upgrade Meshs Surface..., I get the following error:

core/object/message_queue.cpp:222 - Error calling deferred method: 'EditorNode::EditorNode::restart_editor': Method expected 1 arguments, but called with 0.

Then I tested it on a project created from scratch, and the same problem occurs.

Note that before running the new version of Godot I removed the AppData\Local\Godot and AppData\Roaming\Godot folders to ensure there were no conflicts. So the problem should not be related to saved configuration data.

Steps to reproduce

In Editor execute: Project > Tools > Upgrade Meshs Surface...

Minimal reproduction project (MRP)

n/a

[brcontainer]

The possible cause of the problem was this commit: https://github.com/godotengine/godot/commit/aa4077338bfaeeb47e2722891c80636a25d43ada

I think you forgot to apply the adjustments to the following files:

• https://github.com/godotengine/godot/blob/0c45ace151f25de2ca54fe7a46b6f077be32ba6f/editor/surface_upgrade_tool.cpp#L108
• https://github.com/godotengine/godot/blob/0c45ace151f25de2ca54fe7a46b6f077be32ba6f/editor/editor_file_system.cpp#L936
• https://github.com/godotengine/godot/blob/0c45ace151f25de2ca54fe7a46b6f077be32ba6f/modules/gltf/editor/editor_scene_importer_blend.cpp#L602
• https://github.com/godotengine/godot/blob/0c45ace151f25de2ca54fe7a46b6f077be32ba6f/editor/project_settings_editor.cpp#L375
• https://github.com/godotengine/godot/blob/0c45ace151f25de2ca54fe7a46b6f077be32ba6f/editor/fbx_importer_manager.cpp#L124
• https://github.com/godotengine/godot/blob/0c45ace151f25de2ca54fe7a46b6f077be32ba6f/editor/editor_settings_dialog.cpp#L814

I didn’t submit a pull request because I currently don’t have the means to build it and verify if anything else is missing. However, I hope this contribution is helpful.

❤

[AThousandShips]

Only the first line needs changing, the others use the default argument correctly, it should just be changed to:

callable_mp(EditorNode::get_singleton(), &EditorNode::restart_editor).call_deferred(false);