search

goetas-webservices / soap-client

PHP implementation of SOAP 1.1 and 1.2 client specifications
MIT License
175 stars 28 forks source link

Add tests for local elements when elementFormDefault is set #46

Open Toilal opened 4 years ago

Toilal commented 4 years ago

Related to goetas-webservices/xsd-reader#51

This currently adds a test in soap-client matching the issue. (and test is actually failing to demonstrate the issue)

Toilal commented 4 years ago

The test is fixed with both goetas-webservices/xsd2php#108 and goetas-webservices/xsd-reader#52.

I have used https://github.com/gossi/composer-localdev-plugin to symlink to local development packages, works like a charm.

Please wait before merging those pull request, as I wish to add more test cases based on this ID3 Webservice, and try integration in my real world app.

Toilal commented 4 years ago

Hi @goetas

I pretty sure you are really busy on many other subjects, but you could review and merge this pull requests and others related to this one ?

I'm currently running in an app that's now live in production the following patches from my pull requests.

        "patches": {
            "goetas-webservices/soap-client": {
                "Add ID3 wsdl test for local element property": "https://github.com/goetas-webservices/soap-client/pull/46.patch",
                "Add symfony 4+ support": "https://github.com/goetas-webservices/soap-client/pull/47.patch"
            },
            "goetas-webservices/xsd2php": {
                "Use elements local property to generate proper JMS mappings": "https://github.com/goetas-webservices/xsd2php/pull/108.patch"
            },
            "goetas-webservices/xsd-reader": {
                "Add local property to elements": "https://github.com/goetas-webservices/xsd-reader/pull/52.patch"
            }
        }

Everything is working properly with those patches, i'm pretty sure you could merge those pull requests and perform new release with confidence :)

Please let me know, best regards.

goetas commented 4 years ago

Hi, sorry if this is taking so long, but recently i've been really busy.

I'm really interested in https://github.com/goetas-webservices/xsd-reader/pull/52 (and in the scenario that fixes) but I would like to have time to test it a bit better (I tend to follow the SOAP interpretation done by SoapUI... so would like to have some time to test it with it).

I think that the quality of both pull requests is very good, is just that i would like to find time to test them properly.

goetas commented 4 years ago

same note for the tests as in https://github.com/goetas-webservices/xsd2php/pull/108

Toilal commented 4 years ago

Test have been simplified. They fail on CI because they need to run with https://github.com/goetas-webservices/xsd2php/pull/108 and https://github.com/goetas-webservices/xsd-reader/pull/52

goetas commented 4 years ago

Shouldnt we first merge https://github.com/goetas-webservices/xsd2php/pull/108?

To make tests pass you can add @dev in the composer deps, in this way you will get the latest version

goetas commented 4 years ago

https://github.com/goetas-webservices/xsd2php/releases/tag/v0.3.12 has been tagged

Toilal commented 4 years ago

Thanks ! Thanks. I think we also need to release wsdl2php with this change in composer.json : https://github.com/goetas-webservices/wsdl2php/pull/12