Open metalinspired opened 1 week ago
oh, this looks actually super great!! On the other hand looks very hard to review... are your changes "per" commit? Is there any chance you could split it into multiple pull requests?
Turns out there was an issue I missed and caught when trying to serialize. Some elements were being qualified when they should not have been. It is fixed in last commit. Unfortunately I have not been so tidy to do each change per commit. The customer approved the time for me to fix the issues we were facing and I doubt I'll get the time (personal included) to split it into multiple PRs. All I can tell you is that we are now getting classes as we would expect and they serialize just fine to XML which is then validated by another service, before they import it, and validation passes with a green light.
Also I removed removing the setter in JMS definition. I figured it might break old code that implicitly set values for fields that are now populated with fixed/default data.
Here is a list of changes I have made (hopefully I did not forget something):
Note that all my work is based on converting XZuFi 2.3. So far everything seems to work as expected and soon I will be using generated classes and (de)serialization in customer code, which will in it self be a test if I broke something 😄
Oh and another thing, if you run the tests (all of them) it might happen that OTA tests fail but it seems that it is a bug in JMS as one interface defines "parse(): array" but class implementing it returns a string.