search

gogo / letmegrpc

[maintainer wanted] generates a web form gui from a grpc specification
BSD 3-Clause "New" or "Revised" License
419 stars 50 forks source link

Not working with Windows #43

Open Falco20019 opened 6 years ago

Falco20019 commented 6 years ago

The directory list for GOPATH is concatenated using envs[i] + ":" + tmpDir. But Windows needs it to be envs[i] + ";" + tmpDir since the list separator is a semicolon.

awalterschulze commented 6 years ago

Very interesting. Would you like to fix it with a pull request pretty please :D

Falco20019 commented 6 years ago

I don't know GoLang good enough to know how to differentiate between the different OS and what a good solution would look like. I just changed it to semicolon for me and did go install since that fixed it for me. But I'm sure that's not the solution you want in the PR ;-)

awalterschulze commented 6 years ago

Here is a snippet from stack overflow to help.

if runtime.GOOS == "windows" {
    fmt.Println("Hello from Windows")
}

https://stackoverflow.com/questions/19847594/how-to-reliably-detect-os-platform-in-go

The rest should be easy, or am I missing something?