search

goinstant / goangular

AngularJS bindings for GoInstant. Build realtime, multi-user apps with AngularJS and GoInstant easily. https://developers.goinstant.com/v1/GoAngular/index.html
BSD 3-Clause "New" or "Revised" License
137 stars 30 forks source link

fix(sync.js): trim dead branches on set #53

Closed mattcreager closed 10 years ago

mattcreager commented 10 years ago

Related: #52

colinmacdonald commented 10 years ago

LGTM

ianlivingstone commented 10 years ago

Where are the tests for this @mattcreager @colinmacdonald ?

colinmacdonald commented 10 years ago

@ianlivingstone This PR is a hotfix, tests will be done for the next release. https://github.com/goinstant/goangular/issues/52#issuecomment-33840975

ianlivingstone commented 10 years ago

Even hot fixes require tests

Sent from my iPhone

On Feb 1, 2014, at 12:04 PM, colinmacdonald notifications@github.com wrote:

@ianlivingstone This PR is a hotfix, tests will be done for the next release. #52 (comment)

— Reply to this email directly or view it on GitHub.