search

golang / go

The Go programming language
https://go.dev
BSD 3-Clause "New" or "Revised" License
124.34k stars 17.7k forks source link

runtime: use wrappers for op= map operations #26059

Open randall77 opened 6 years ago

randall77 commented 6 years ago

CL 120255 made mapdelete zero the value all the time, to make sure op= map operations work correctly. Probably we should do wrapper functions for op= operations so we don't need to zero during all map deletes.

@vkuzmin-uber @martisch

vkuzmin-uber commented 6 years ago

Looking on it.

randall77 commented 6 years ago

@vkuzmin-uber : For some reason I can't assign you to this issue. I tried and failed.

dominikh commented 6 years ago

@randall77 that's what the go-assignees role exists for. Only members of some role in the organization can be assigned issues.

gopherbot commented 6 years ago

Change https://golang.org/cl/139101 mentions this issue: runtime: use wrappers for op= map operations

vkuzmin-uber commented 6 years ago

Just published change that works. I consider this as a proof of concept and feel free to suggest another design. About "go-assignees role" - please let me know if I can do something to get it.